Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iwd2: glacier melting cutscene inaccuracies #1510

Closed
12 tasks done
lynxlynxlynx opened this issue Jan 1, 2022 · 3 comments
Closed
12 tasks done

iwd2: glacier melting cutscene inaccuracies #1510

lynxlynxlynx opened this issue Jan 1, 2022 · 3 comments
Labels
bug game: iwd2 research needed usually means testing in the original, to see how it behaved system: animations system: core core engine stuff system: projectiles system: scripting pertaining to scripts and dialogs
Milestone
0.9.3 - TBN

Comments

@lynxlynxlynx
Copy link
Member

lynxlynxlynx commented Jan 1, 2022 •
edited

Original:
https://youtu.be/uENgjVDJiTw?t=110

This is the 41cnatew cutscene.

  • fades are still busted
  • casting glow is too long
  • there is no fake casting sound
  • the glacier is disintegrated too fast / timing doesn't add up narratively
    • the glow should fade before disintegration effects are visible
  • there is no disintegration visuals
  • there is a door opening sound
  • they are not wearing their helmets Helmet drawing regression  #1512
  • Ingrath should stop sooner, since he's using MoveToObjectUntilSee
  • Ingrath has an odd path and walks backwards
  • casting stance is too long (casting faked via PlaySequence) We need a simple way to draw a single cycle of a char animation #1513
  • the reinforcements should cluster around their leaders
@lynxlynxlynx lynxlynxlynx added bug game: iwd2 system: scripting pertaining to scripts and dialogs labels Jan 1, 2022
@lynxlynxlynx lynxlynxlynx self-assigned this Jan 1, 2022
lynxlynxlynx added a commit that referenced this issue Jan 1, 2022
@lynxlynxlynx
fx_iwd_visual_spell_hit: improve the workaround from #1028
ae0e73d 
restores some missing visuals in this and other scenes, eg. #1510
lynxlynxlynx added a commit that referenced this issue Jan 1, 2022
@lynxlynxlynx
GameScript::SpellCastEffect: fix timing and block, part of #1510
da86fc0 
thanks Bubb!
lynxlynxlynx added a commit that referenced this issue Jan 1, 2022
@lynxlynxlynx
OpenDoor: never play a sound
9a50e3d 
iwd1 does it manually, eg. Angaar in bcclgate.bcs
fixes Nathaniel's icewall melt making a sound #1510
lynxlynxlynx added a commit that referenced this issue Jan 2, 2022
@lynxlynxlynx
GameScript::SpellHitEffectPoint: wait for a tick #1510
ae9af77
@lynxlynxlynx lynxlynxlynx mentioned this issue Jan 2, 2022
Closed
lynxlynxlynx added a commit that referenced this issue Jan 2, 2022
@lynxlynxlynx
Projectile::ChangePhase: only stop the travel sound if another is ava…
40c9cec 
…ilable #1510

potentially wrong, but fixes the sound timing in iwd2 41cnatew.bcs triggered by
SpellHitEffectPoint projectiles
lynxlynxlynx added a commit that referenced this issue Jan 2, 2022
@lynxlynxlynx
fx_casting_glow: added mode for SpellCastEffect #1510
8337acf
lynxlynxlynx added a commit that referenced this issue Jan 2, 2022
@lynxlynxlynx
MoveToObjectUntilSee: actually stop movement when done #1510
3cdbcb0
lynxlynxlynx added a commit that referenced this issue Jan 2, 2022
@lynxlynxlynx
CanSee: used the halved visual range for actors
7f1c269 
fixes the too long range for #1510, matches the re confusion,
but could also break a lot of other stuff
perhaps it will need to be ifdefed or used with more complex logic
@lynxlynxlynx lynxlynxlynx added research needed usually means testing in the original, to see how it behaved system: animations system: core core engine stuff system: projectiles labels Jan 2, 2022
@lynxlynxlynx
Copy link
Member Author

lynxlynxlynx commented Jan 2, 2022 •
edited

Ingrath is now nicely placed, but his groupies will have to be checked on a clean save.

To test just run in ar4100: SetGlobal("41NateDestroySourceQuest","GLOBAL",4)
(and create the 11genden item if you want the same process as in the video)

lynxlynxlynx added a commit that referenced this issue Jan 2, 2022
@lynxlynxlynx
do c27d896 the other way around, so more careful placement is preserved
86da4ef 
part of #1510, since the icewall door is blocking when closed and
throws Ingrath away
@lynxlynxlynx lynxlynxlynx removed their assignment Jan 15, 2022
@lynxlynxlynx lynxlynxlynx added this to the 0.9.2 - TBN milestone Jul 2, 2022
@lynxlynxlynx lynxlynxlynx modified the milestones: 0.9.2 - TBN, 0.9.3 - TBN May 2, 2023
@lynxlynxlynx
Copy link
Member Author

lynxlynxlynx commented Mar 29, 2024 •
edited

His soldiers get there faster, so he can't enter the spot where he's supposed to be and 50letter.bcs gets stuck. Ok, that only happened once in a several tries, not so bad.
image
And if you don't have the item, it's easy to hit a severe corruption (canary dies), something probably related to #1913.

@lynxlynxlynx
Copy link
Member Author

Ok, nevermind, was cheating the cutscene from the wrong context. So the last item can be ticked, but I noticed the skulltrap didn't trigger, so one more thing before closing ...

lynxlynxlynx added a commit that referenced this issue Mar 30, 2024
@lynxlynxlynx
trapskul: shortened fuse; in bg2 this is done by the fixpack
d95aa25 
fixes ingrath letter bomb not going off immediately #1510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug game: iwd2 research needed usually means testing in the original, to see how it behaved system: animations system: core core engine stuff system: projectiles system: scripting pertaining to scripts and dialogs
Projects
None yet
Milestone
0.9.3 - TBN
Development

No branches or pull requests
1 participant
@lynxlynxlynx