Pathfinder upgrade #126
Merged
Pathfinder upgrade #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! I updated a few details in #106 yesterday, all regarding to the various npc bumping aspects. |
gemrb/core/PathFinder.cpp
Outdated
| // target (the goal must be in sight of the end, if PF_SIGHT is specified) | ||
| PathNode *Map::FindPath(const Point &s, const Point &d, unsigned int size, unsigned int minDistance, int flags, const Actor *caller) const | ||
| { | ||
| Log(DEBUG, "FindPath", "s = (%d, %d), d = (%d, %d), caller = %s, dist = %d, size = %d", s.x, s.y, d.x, d.y, caller ? caller->GetName(0) : "NULL", minDistance, size); |
There was a problem hiding this comment.
Time to go or should we wait a bit?
Suggested change
| Log(DEBUG, "FindPath", "s = (%d, %d), d = (%d, %d), caller = %s, dist = %d, size = %d", s.x, s.y, d.x, d.y, caller ? caller->GetName(0) : "NULL", minDistance, size); |
There was a problem hiding this comment.
This is less frequent. I think we can leave it in for now, and if somebody complains about a spam of these it's either an issue or we can just remove it then. If nobody complains about it for, say, a month, then I guess it can go.
kmfrick
changed the title
|
Issues
======
+ Solved 2
Clones removed
==============
+ gemrb/core/Map.cpp -15
See the complete overview on Codacy |
|
Thanks for taking this long path with me! 🎆 |
I hope these commits find their new home comfortable! ❄️(sorry, had to do this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist