Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ControlAnimation: palette updates on pause #82

Merged
merged 1 commit into from Apr 6, 2018

Conversation

MarcelHB
Copy link
Collaborator

@MarcelHB MarcelHB commented Apr 5, 2018

When playing IWD2 and hitting Pause, then changing into the inventory, the paperdoll's palette is never adjusted, so we see this standing frozen:

paperdoll

UpdateAnimation will always either skip updating or proceed in frames, which is both not fully what is useful here. I reworked that a little in a way that SetPaletteGradients will cause redraw without continuing the animation.

The whole thing has some annoying design, but at least this will stop rainbow colours here.

Otherwise, when the game indicates pausing, colors never become updated.
@lynxlynxlynx
Copy link
Member

Thanks, looks pretty clean to me. Any thoughts @bradallred?

@bradallred
Copy link
Member

I certainly don't see anything wrong here. seems like any setter ought to update it tho. any harm in adding it to SetBlend?

@MarcelHB
Copy link
Collaborator Author

MarcelHB commented Apr 5, 2018

Maybe, since the only actual use case puts that right in front of UpdateAnimation: https://github.com/gemrb/gemrb/blob/master/gemrb/plugins/GUIScript/GUIScript.cpp#L5539

@bradallred
Copy link
Member

Yeah, probably nothing to worry about. I dont know enough about it to make any improvement suggestions so I would say merge it.

@lynxlynxlynx lynxlynxlynx merged commit 7cb9568 into gemrb:master Apr 6, 2018
@MarcelHB MarcelHB deleted the ctlanim_palettes branch April 6, 2018 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants