Win64 fixes for finding files and making directories #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks! Why is the strtok change needed though, surely nulls are not valid path chars on windows? |
|
strtok expects a 0-terminated string as its second parameter. As luck would have it, PathDelimiter wasn't followed by a 0 in my builds, but by 'c', so "Cache2" was split in to "Ca" and "he2", making a wrong folder with a subfolder. |
|
uff, even the man page doesn't mention that. Good catch! |
3 tasks
MarcelHB
pushed a commit
to MarcelHB/gemrb
that referenced
this pull request
Sep 9, 2019
the viewport needs to always get updated so we need something to call from either Freeze() or Update() fixes viewport not scrolling to dialog speaker if DF_FREEZE_SCRIPTS is set issue gemrb#85
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to build and run on 64-bit Windows, had to change a couple lines that assumed 32-bit. Also strtok was called with a wrong constant.