windows 10 version not recognized

[xiorcal]

hi!

trying to use a basic err := beeep.Notify("Title", "Message body", "assets/icon128.png")
I go t the following panic : panic: exec: "msg": executable file not found in %PATH%

I dug a little and found that getWindowsVersionString() returns unknown on my computer

package main

import (
	"bytes"
	"fmt"
	"os/exec"
	"strings"
)

func main() {
	cmd := exec.Command("cmd", "ver")
	var out bytes.Buffer
	cmd.Stdout = &out
	err := cmd.Run()
	if err != nil {
		panic(err)
	}
	fmt.Println(out.String())
	s := strings.Replace(out.String(), "\r\n", "", -1)
	p1 := strings.Index(s, "[Version")
	p2 := strings.Index(s, "]")
	var ver string
	if p1 == -1 || p2 == -1 {
		ver = "unknown"
	} else {
		ver = s[p1+9 : p2]
	}
	fmt.Printf("%v\n", ver)
}

outputs

go run .\main.go
Microsoft Windows [version 10.0.16299.192]
(c) 2017 Microsoft Corporation. Tous droits r�serv�s.


unknown

seems to me that it comes from the lower case "version" instead of the expected "Version"

[xiorcal]

i'm making a PR

[Equim-chan]

We can't assume the client is always running Windows in English.

On my platform, cmd ver prints

Microsoft Windows [版本 10.0.16299.192]
(c) 2017 Microsoft Corporation。保留所有权利。
...

>cmd ver < NUL | xxd
00000000: 4d69 6372 6f73 6f66 7420 5769 6e64 6f77  Microsoft Window
00000010: 7320 5bb0 e6b1 be20 3130 2e30 2e31 3632  s [.... 10.0.162
00000020: 3939 2e31 3932 5d0d 0a28 6329 2032 3031  99.192]..(c) 201
00000030: 3720 4d69 6372 6f73 6f66 7420 436f 7270  7 Microsoft Corp
00000040: 6f72 6174 696f 6ea1 a3b1 a3c1 f4cb f9d3  oration.........
...

The best fix should be querying registry directly instead of using this trick. I'll try to make a PR soon.