Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javascript build, removing gopherjs in favour of syscall/js #45

Merged
merged 2 commits into from
Apr 2, 2022

Conversation

prologic
Copy link
Contributor

No description provided.

@gen2brain
Copy link
Owner

Thanks, I saw that gopherjs is archived, just didn't find the time to do it. Why remove go.sum though?
Also, can interface{} be used instead of any? Don't want to force the version of Go to the latest if there is no need.

@prologic
Copy link
Contributor Author

Thanks, I saw that gopherjs is archived, just didn't find the time to do it. Why remove go.sum though? Also, can interface{} be used instead of any? Don't want to force the version of Go to the latest if there is no need.

Not sure why go.sum was removed, I'll fix 👌

As for Go 1.18 -- I'll try and see if my project still builds.

@prologic
Copy link
Contributor Author

Yup still builds okay 👌

=> https://git.mills.io/saltyim/saltyim/pulls/108

@prologic prologic changed the title Fix syscall.JS and update go Go 1.18 Fix Javascript build, removing gopherjs in favour of syscall/js Mar 31, 2022
@prologic
Copy link
Contributor Author

@gen2brain Note that I haven't actually removed go.sum at all, this is just the result of running go mod tidy.

@gen2brain
Copy link
Owner

Ah, ok, good. What about any, can you replace it with the interface{}?

@prologic
Copy link
Contributor Author

prologic commented Apr 1, 2022

Ah, ok, good. What about any, can you replace it with the interface{}?

Ahh yes sorry I forgot 😅

@prologic
Copy link
Contributor Author

prologic commented Apr 1, 2022

Done

@gen2brain gen2brain merged commit 6a3042f into gen2brain:master Apr 2, 2022
@gen2brain
Copy link
Owner

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants