New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bridging ChEBI to Pro #12341
Comments
I'm sure there's at least one open ticket about this, see if I can find On 10 Mar 2016, at 11:48, David Osumi-Sutherland wrote:
|
Relevant PRO ticket: https://sourceforge.net/p/pro-obo/term-requests/99/ |
Darren has promised to fix this (even if ticket says otherwise). But I'm not inclined to rely on it. |
Let's do this correctly. The equiv is more of an issue if it's to a class i the release ontology (eg GO/CL)
What about OE? Does anyone every axiomatize in OE any more? I use OFUL a lot in Protege, but when people don't have this configured it can lead to real confusion Another option is just to rewire the label in our import module
It would be great if PRO and CHEBI could take the lead here and come up with a solution |
PRO and ChEBI long ago agreed that terms such as 'glycoprotein' should live in PRO, and we do indeed have that term and others similar to it (since 2013 or so), and can certainly add more as needed. From my recollection the only reason ChEBI has them at all is because there is one user group that expects to see them there. As for that relevant PRO ticket: https://sourceforge.net/p/pro-obo/term-requests/99/ and the action I promised despite its closure, changes that relate PRO to ChEBI have indeed been implemented. The request evolved into relating PRO's protein to ChEBI in a chemical sense. I've attached an OBO file showing the relevant terms as they are today (note: I had to change the extension to 'txt' so it would upload here). For simplicity I've changed the parents for some ChEBI terms to 'molecular entity' The changes to PRO were made in consultation with John Garavelli ("Dr. MOD") and account for the fact that proteins are not technically just chains of amino acid residues (which, by ChEBI's definition, are only peptidyl). I'm not sure if the changes made address the peptide vs protein issue. Likely not. PRO has shied away from using the term peptide because the distinction between the two is so arbitrary, and we cannot place protein under peptide because of the issue mentioned directly above; that is, not all proteins are peptides by ChEBI's definition of peptide. Indeed, I believe this might mean that not all PRO proteins are ChEBI proteins, confusingly enough. John indicated he tried to convince ChEBI curators to change their definition at some point but they resisted. |
Edit: it appears that ChEBI has decoupled protein and peptide in such a way as to no longer be a direct problem. That is, the is_a hierarchy is now a has_part (protein has part peptide, after a few steps). My understanding from John is that there was still some issue somewhere (I think with the definition of amino acid residue and the concern about modified residues found in proteins), but that the issue is resolved by the changes given in the attached file. |
|
Hi @dosumis: is that change live yet, or...? |
Not live yet. I'd rather not break the build overnight, so will try first thing tomorrow. (NOTE TO SELF: Ready for commit). |
|
Changes are now live. Build didn't break. Changes to inference can be viewed here:
Additions look good ( @ukemi please can you check?). But some lost inferences need investigating, e.g.: [Term] May be harmless redundancy stripping. Checking now. |
From spot checking - all removed inferences appear to be harmless redundancy stripping (the relevant classifications are now on superclasses). |
Fixed mappings from CHEBI to SO. Effects on inference are not visible in initial commit as mostly asserted. Note there is some duplication between SO and CHEBI (messenger RNA etc in CHEBI). The fact that the CHEBI versions are in bold here shows that they are used in GO axioms. Either all usages should be standardised to SO, or we should add additional equivalence axioms to the bridge file. |
Inference resulting from assertion of SO - CHEBI logical links can be seen here: http://viewvc.geneontology.org/viewvc/GO-SVN/trunk/ontology/editors/go_inferences_difflog.txt (There are a few other inferences on proteins, due to tweaks based on issues found with inference after equivalence between CHEBI and PRO protein added (see above). Relevant commit = -r38127.) |
Editor's call: we agreed to close this ticket and move the one remaining item (BFO import) to a fresh ticket. |
We use pro:Protein as a general way to refer to proteins in axioms. But we also use some subclasses of ChEBI protein, e.g. glycoprotein, lipoprotein. For full inference we need these to sit under whatever term we use for Protein.
PRO have promised in the past to fix their references to ChEBI. We should probably follow up on this. In the absence of a PRO fix, we may be able to fix by adding out own bridging axiom or by switching purely to PRO.
The text was updated successfully, but these errors were encountered: