Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All terms below "centrosome cycle" should be taxonomically restricted for fungi #15685

Closed
ValWood opened this issue May 2, 2018 · 16 comments · Fixed by #16496
Closed

All terms below "centrosome cycle" should be taxonomically restricted for fungi #15685

ValWood opened this issue May 2, 2018 · 16 comments · Fixed by #16496

Comments

@ValWood
Copy link
Contributor

ValWood commented May 2, 2018

centrosome cycle
https://www.ebi.ac.uk/QuickGO/term/GO:0007098

has
GO:0007098 | centrosome cycle | Never in Taxon | 4751 | Fungi

but the descendant
GO:0046604 positive regulation of mitotic centrosome separation
does not, and we are getting PAINT mappings for this.

All terms below "centrosome cycle" should be taxonomically restricted for fungi (unless we decide to combine the orthologous structures of "centrosome" and "spindle pole body" in GO (some authors do not refer to the SPB as the centrosome). However ups to now we have annotated to mutually exclusive branches following a more "traditional" view.

A merging of these branches would be quite a lot of work, and while they are separated in this way, centrosome terms should all be unavailable for fungal annotations.....

@ValWood
Copy link
Contributor Author

ValWood commented May 2, 2018

also
regulation of cell migration
should have the same taxon restrictions for dikarya as the parent terms

@mah11
Copy link
Collaborator

mah11 commented May 2, 2018

hmm, I thought never_in_taxon and only_in_taxon were supposed to propagate "down" via transitive relations already, so I guess the issue is to propagate over regulates as well?

(or does that also already happen? ... which would make this another PAINT problem)

@ValWood
Copy link
Contributor Author

ValWood commented May 2, 2018

hmm, I thought never_in_taxon and only_in_taxon were supposed to propagate "down" via transitive relations already,

well they used to, but they don't any longer -apparently because of the "regulation via another organism" stuff which is now allowed. I don't think that pathogens should use the same terms as the hosts, they aren't regulating the same processes. It was much better when pathogen terms were in an independent branch IMHO.....

@pgaudet
Copy link
Contributor

pgaudet commented May 2, 2018

Hi @ValWood

The taxon constraints are propagated down (in principle). However there are problems with the implementations of taxon constraints for PAINT annotations. I'm marking this 'Rules' to check with @dougli1sqrd or @cmungall
Pascale

@cmungall
Copy link
Member

cmungall commented May 2, 2018

sorry, not sure what the action required here is

@pgaudet
Copy link
Contributor

pgaudet commented May 3, 2018

@cmungall Where can we look at taxon constraints error reports ?

@ValWood
Copy link
Contributor Author

ValWood commented May 3, 2018

taxon checks are not currently implemented:
geneontology/go-annotation#1928

but, when they are,
GO:0046604 positive regulation of mitotic centrosome separation
is not taxonomically restricted, even though the parent GO:0007098 centrosome cycle is.

@pgaudet pgaudet assigned pgaudet and unassigned cmungall Aug 28, 2018
@pgaudet
Copy link
Contributor

pgaudet commented Aug 28, 2018

This seems to be still a problem with the PAINT annotation imports -

centrosome cycle
https://www.ebi.ac.uk/QuickGO/term/GO:0007098

is not annotated according to Pantree:
http://www.pantree.org/node/annotationNode.jsp?id=PTN001061464

@dustine32 is this anywhere in the files exported by the PAINT pipeline ?

@ValWood
Copy link
Contributor Author

ValWood commented Aug 28, 2018

centrosome cycle was supposed to merge into centrosome organiszation?
#13247

@pgaudet
Copy link
Contributor

pgaudet commented Aug 29, 2018

Species annotated are non-MOD species; so it's probably related to this:
geneontology/amigo#533

@dustine32
Copy link
Contributor

@pgaudet Looks like it is related to the old PAINT _other.gaf issue geneontology/amigo#533. Checking the last few months worth of "_other.gaf" files submitted by PAINT, I can't find any lines at all for GO:0046604. However, the GO:0046604 IBAs shown in amigo do appear in this GAF:
http://www.geneontology.org/gene-associations/submission/paint/pre-submission/gene_association.paint_other.gaf

@pgaudet
Copy link
Contributor

pgaudet commented Oct 2, 2018

Hi @dustine32

Is PAINT now filtering out the annotations that fail taxon constraints ? (It doesn't look like it - for example http://amigo.geneontology.org/amigo/gene_product/UniProtKB:A0A0D1DU59 (UMAG_03898) should not have an annotation to GO:0010824 regulation of centrosome duplication.

Can you please let me know where we stand with respect to filtering these annotations?

Thanks, Pascale

@pgaudet
Copy link
Contributor

pgaudet commented Oct 2, 2018

Although - do taxon constraints propagate down 'regulation'?
@cmungall @dougli1sqrd

@pgaudet
Copy link
Contributor

pgaudet commented Oct 9, 2018

@ukemi do you know if taxon constraints propagate down 'regulation'?

@ukemi
Copy link
Contributor

ukemi commented Oct 9, 2018

I don't believe they do. If they do, I don't think they should. It is possible for one organism to regulate a process in another organism even if the target process is restricted. I thought we had this discussion previously.

@pgaudet
Copy link
Contributor

pgaudet commented Oct 9, 2018

Good to know ! I'll add it for these terms.

@ukemi ukemi moved this from ontology call Oct 15? to Ontology meeting Oct 15 in ontology weekly meetings Oct 12, 2018
@pgaudet pgaudet removed this from Ontology meeting Oct 22 in ontology weekly meetings Oct 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants