Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question design patterns for regulation #16504

Open
pgaudet opened this issue Oct 12, 2018 · 5 comments
Open

Question design patterns for regulation #16504

pgaudet opened this issue Oct 12, 2018 · 5 comments

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Oct 12, 2018

Hello,

For biological regulation terms, we have 3 possible genera:

  • some terms start with: 'biological process' and 'regulates' some 'x'
  • other have 'biological regulation' and 'regulates' some 'x'
  • and others have 'regulation of biological process' 'regulates' some 'x' (for eg GO:1900400)

Is this OK ? Do we want to make all these uniform ? (the ontology documentation gives instructions to do the second option here).

Thanks, Pascale

@ukemi
Copy link
Contributor

ukemi commented Oct 12, 2018

I thought @cmungall had said we would use whatever is in the design pattern template.

@pgaudet
Copy link
Contributor Author

pgaudet commented Oct 12, 2018

Right - so it's 'biological regulation' and 'regulates' some %s" (https://github.com/geneontology/go-ontology/blob/master/src/design_patterns/regulation.yaml).

Can all terms with a different logical definition be changed ? (we may have another ticket for that somewhere).

Thanks, Pascale

@ukemi
Copy link
Contributor

ukemi commented Oct 12, 2018

I thought there was already a ticket out there to have that done by script.

@ValWood
Copy link
Contributor

ValWood commented Nov 5, 2020

Is this current?

@cmungall
Copy link
Member

cmungall commented Nov 6, 2020

$ obo-grep.pl  -r 'intersection_of: GO:0008150' go-edit.obo | obo-grep.pl -r 'intersection_of: regulates ' - | grep -c '^id:'
3294
$ obo-grep.pl  -r 'intersection_of: GO:0065007' go-edit.obo | obo-grep.pl -r 'intersection_of: regulates ' - | grep -c '^id:'
228

still 228 with BR as genus

happy to close this issue as this should all fall out of DP work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

4 participants