Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing parent: [GO term] regulation of biological quality #24125

Open
ValWood opened this issue Oct 4, 2022 · 6 comments
Open

Missing parent: [GO term] regulation of biological quality #24125

ValWood opened this issue Oct 4, 2022 · 6 comments

Comments

@ValWood
Copy link
Contributor

ValWood commented Oct 4, 2022

Lots of issues with the "regulation of biological quality" branch, but it seems the best parent for these terms:

GO:0031413 regulation of buoyancy
GO:0060378 regulation of brood size

@balhoff
Copy link
Member

balhoff commented Oct 4, 2022

Both of these should be classified automatically under there, but they have logical definitions that refer to obsolete terms. I would have expected this to be caught in a check; I'll look into it.

@balhoff
Copy link
Member

balhoff commented Oct 7, 2022

Both of those terms referenced OBA biological attributes that have been obsoleted and moved to PATO. But our 'regulation of biological quality' pattern (https://github.com/geneontology/go-ontology/blob/master/docs/patterns/regulation_of_characteristic.md) specifies 'biological attribute' as the filler range, not any PATO characteristic/quality. For that reason these two terms still don't classify under 'regulation of biological quality'. We can discuss changing the pattern in our upcoming design patterns discussion.

@pgaudet
Copy link
Contributor

pgaudet commented Nov 17, 2023

At the Jan 2021 (?) jamboree we had discussed to obsolete this branch, this is a bunch of phenotypes.

I would be tempted to close this for now, as this is a huge project.

@ValWood
Copy link
Contributor Author

ValWood commented Nov 17, 2023

It probably isn't as huge as it seems. Many of these terms just need this parentage removed. That could be a first step.
This would be an improvement because it would mean that terms like vasodilation, lactation, lumen formation, ecdysone biosynthetic process, open tracheal system etc etc, would no longer be is_a biological regulation

@pgaudet
Copy link
Contributor

pgaudet commented Nov 17, 2023

Right !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants