Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling interacting taxon data - has_input to the relevant BP? #237

Closed
vanaukenk opened this issue Sep 24, 2020 · 11 comments
Closed

Handling interacting taxon data - has_input to the relevant BP? #237

vanaukenk opened this issue Sep 24, 2020 · 11 comments
Assignees
Labels
question Further information is requested

Comments

@vanaukenk
Copy link
Contributor

In WB, we have a number of annotations to terms like 'defense response to Gram negative bacterium' where we've indicated the specific type of bacteria in the interacting taxon field of the GPAD file.

For GO-CAMs, we could capture this as an input to the BP, e.g. 'has input' NCBITaxon:287, but we'd need to update the BP shape to do this.

@ukemi @dustine32 @thomaspd @pgaudet @cmungall @goodb

Any thoughts on, or objections to, handling interacting taxa data this way?

@vanaukenk vanaukenk added the question Further information is requested label Sep 24, 2020
@vanaukenk vanaukenk self-assigned this Sep 24, 2020
@ukemi
Copy link

ukemi commented Sep 24, 2020

Is an NCBITaxon an organism? We have a few annotations like this too if I remember correctly.

@vanaukenk
Copy link
Contributor Author

This is what we currently have declared at the top of the ShEx:

PREFIX GoOrganism: http://purl.obolibrary.org/obo/NCBITaxon_1

@vanaukenk
Copy link
Contributor Author

vanaukenk commented Sep 29, 2020

From 2020-09-29 call:

We discussed on the GO-CAM specifications call whether 'has input' really is the best relation for a process that involves another organism, like 'defense response to Gram negative bacterium'.

Perhaps a new RO relation that is a sibling to 'has input' would be better, but we need to come up with a good definition.

Logical definition for 'defense response to bacterium': defense response and ('has_input' some Bacteria)

Will add this ticket as an agenda item to the next ontology call.

@pgaudet
Copy link
Contributor

pgaudet commented Sep 30, 2020

There are a number of existing relations that could work:

'symbiotically interacts with'
'host of'
'has pathogen'
'parasitized by'

Thanks, Pascale

@vanaukenk
Copy link
Contributor Author

vanaukenk commented Oct 19, 2020

Here's the hierarchy of the above relations in RO:

image

I have questions about the meaning of 'symbiotically' in the context of a defense response, given how its usage is described in the comment, i.e. 'mutualism through parasitism'.

We can discuss further on the ontology call.

@ValWood
Copy link

ValWood commented Oct 19, 2020

This aligns with the solution me and my PHI-Base colleagues have been angling for.

geneontology/go-ontology#19430
(and lots of related problems with these terms noted in other tickets, mainly about problems related to aligning other terms with this branch).
We have a big issue with the "response to organism terms" anyway because people are using these instead of the appropriate process describing the interaction under this branch
https://www.ebi.ac.uk/QuickGO/term/GO:0051702
--https://www.ebi.ac.uk/QuickGO/term/GO:0051851

I would say we should take this further and have only 'defense response to symbiont' (or host) and all the rest of the species information should be done via a taxon relationship. Otherwise the ontology is difficult to navigate and maintain.

Also, the defenses are largely similar, or overlapping- molecules are recognised (usually carbohydrates, or glycoproteins) not species. The processes these molecules activate are the same, but we end up with kingdom, or domain, family specific processes to describe the same thing).

@pgaudet
Copy link
Contributor

pgaudet commented Oct 19, 2020

I agree - also it would help keep terms not relevant to the scope of GO out of the ontology.

@pgaudet
Copy link
Contributor

pgaudet commented Oct 19, 2020

Decision on the ontology call is to keep using has_input - until we come up with a better solution.

Has input implies that there is a change in the input - but this is usually the case, different gene products are being expressed during the response.

@vanaukenk
Copy link
Contributor Author

@dustine32

For an imported annotation that looks like this in the GPAD:

WB:WBGene00003374 RO:0002331 GO:0050829 PMID:25274306|WB_REF:WBPaper00045829 ECO:0000316 WB:WBGene00004978 NCBITaxon:287 2017-03-10 WB id=GOA:2114107133|comment=go_evidence:IGI

This is what the resulting imported annotation would look like in Noctua:

image

@dustine32
Copy link

Thanks @vanaukenk ! As you can see, I made a ticket here: geneontology/gocamgen#85

@vanaukenk
Copy link
Contributor Author

The ShEx has been updated, so I'm closing this ticket.

We can continue to track progress on the related gocamgen ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants