-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GO refs need checking to make sure that they are actually frontmatter/yamldown #1003
Comments
Tagging @dougli1sqrd , let's talk about this later on. |
I thought this was one of the GO rules ? (maybe not yet implemented). Pascale |
No, this is a syntax check separate from go-rules |
Talked to @dougli1sqrd and will copy what we do for the rules checks with schema in travis. |
Talking with @dougli1sqrd , at least for now we'd like to "generalize" sparta to be able to schema check yamldown/frontmatter on more than just gorules. This would involve pretty much just pushing the glob to the command line and adjusting the travis checks accordingly. |
I believe this can be closed with the merging of #1006 |
@dougli1sqrd @cmungall If #1006 does not break anything or make matters worse, let's just go with it for now--it's currently blocking further progress on #993 as it requires actually clean gorefs files (which are fixed in #1006 ) |
Now in place. |
Currently, while gorefs treated as if they were yamldown/frontmatter, they do not actually parse as such. There is a retroactive fix in the works (see #1001 and #1002 ), but we should add something to travis to ensure that there is not a problem on PRs. I'd naively assume that we could replicate what we do to make the gorules compliant.
The text was updated successfully, but these errors were encountered: