Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GO refs need checking to make sure that they are actually frontmatter/yamldown #1003

Closed
kltm opened this issue Feb 16, 2019 · 9 comments
Closed

Comments

@kltm
Copy link
Member

kltm commented Feb 16, 2019

Currently, while gorefs treated as if they were yamldown/frontmatter, they do not actually parse as such. There is a retroactive fix in the works (see #1001 and #1002 ), but we should add something to travis to ensure that there is not a problem on PRs. I'd naively assume that we could replicate what we do to make the gorules compliant.

@kltm
Copy link
Member Author

kltm commented Feb 16, 2019

Tagging @dougli1sqrd , let's talk about this later on.

@pgaudet
Copy link
Contributor

pgaudet commented Feb 18, 2019

I thought this was one of the GO rules ? (maybe not yet implemented).

Pascale

@cmungall
Copy link
Member

No, this is a syntax check separate from go-rules

@kltm
Copy link
Member Author

kltm commented Feb 21, 2019

Talked to @dougli1sqrd and will copy what we do for the rules checks with schema in travis.

@kltm kltm self-assigned this Feb 21, 2019
kltm added a commit that referenced this issue Feb 21, 2019
@kltm
Copy link
Member Author

kltm commented Feb 21, 2019

Talking with @dougli1sqrd , at least for now we'd like to "generalize" sparta to be able to schema check yamldown/frontmatter on more than just gorules. This would involve pretty much just pushing the glob to the command line and adjusting the travis checks accordingly.
If I get ahead of @dougli1sqrd on this, I may try something nasty with renaming the files in the travis check that should be undone later.

@kltm
Copy link
Member Author

kltm commented Feb 22, 2019

I believe this can be closed with the merging of #1006

@dougli1sqrd
Copy link
Contributor

@cmungall @kltm,

just extract the yaml, convert to json, and validate.

This is exactly what the validator does in sparta. It just assumes the file names (when using a directory) are named gorule. The change in sparta would be to pass in the glob.

@kltm
Copy link
Member Author

kltm commented Feb 25, 2019

@dougli1sqrd @cmungall If #1006 does not break anything or make matters worse, let's just go with it for now--it's currently blocking further progress on #993 as it requires actually clean gorefs files (which are fixed in #1006 )

@kltm
Copy link
Member Author

kltm commented Feb 25, 2019

Now in place.

@kltm kltm closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants