-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a URL in the Noctua contributor field #1615
Comments
How about just giving us the orcids of all pathway curators at SGD and we can attribute all to all? Ideally the ShEx specification would be able to answer these kinds of questions authoritatively. Unfortunately it is underspecified right now
regardless of whether contributor is modeled as a string or URI (I agree it should be URI, but we should have a ticket to change this if we need to), this is our central specification and it should give more guidance on how these fields are to be filled in. I believe shex has a pattern construct so we can place a regex is here to constrain this, e.g. to I would write the documentation for contributor something like this: The value of the contributor field MUST be string literal. The value MUST be a URL that indicates the specific individual that provided some contribution to the model. Refer to dublincore for details. The value SHOULD be an ORCID, but in cases where an ORCID is unavailable (e.g the curation was done in a system outside Noctua) then other URLs indicating the individual MAY be used. The contributor SHOULD always denote an individual curator but in cases where we cannot retrieve a single individual (e.g. performed outside Noctua and done by a group) another URL, e.g. https://pathway.yeastgenome.org may be used to denote a collection of individuals. Note that the provided_by field should be used to indicate groups of people. Note the use of ISO specification language. We need similar docs for provided_by We do need a way to represent the full provenance, that this came from https://pathway.yeastgenome.org/YEAST/NEW-IMAGE?object=YEAST-DE-NOVO-PYRMID-DNT - how are we doing this for Reactome @dustine32 ? |
@cmungall Reactome is doing the same as YeastCyc:
YeastCyc contributor is actually based on Reactome already using this pattern. |
@ukemi correct me if I'm wrong, but my understanding of why the Reactome URL was used in the contributor field is that the link would actually take people to a Reactome page that lists the people (curators and researchers) who authored and reviewed the model. For the MOD imports, we have run into cases where former curators don't have an ORCID and we've instead used the GOC uri in the users.yaml file, for example GOC:cab1. nickname: 'Carol Bastiani' Note that we also have entries currently in the users.yaml to denote groups of curators: nickname: 'Curators at SGD' We also discussed on today's Alliance call using a new metadata tag for GO-CAMs from other pathway resources to indicate the source model so that the contributor field would always correspond to an individual or group of individuals from the users.yaml file. @lpalbou was this proposed tag, in fact, 'source' or something else? It'd be good to get all this nailed down as there are implications for Noctua as well, e.g. the Contributor field on the landing page currently lists users with ORCIDs but that will exclude some contributors included in the soon-to-be imported MOD data. |
contributor has been set to GOC:sgd_curators from other tickets |
Currently, all pathways imported from Yeast Pathways has a unique contributor, e.g.
http://noctua-dev.berkeleybop.org/editor/graph/gomodel:YEAST-DE-NOVO-PYRMID-DNT?
lists
contributor https://pathway.yeastgenome.org/YEAST/NEW-IMAGE?object=YEAST-DE-NOVO-PYRMID-DNT
We'd like to simplify this and truncate the URL, so every model would have
contributor https://pathway.yeastgenome.org
This would need to be added to users.yaml, and some considerations from @dustine32:
The text was updated successfully, but these errors were encountered: