Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorule-0000003 and gorule-0000005 dont show up in the reports #2039

Closed
pgaudet opened this issue Jul 27, 2023 · 7 comments
Closed

gorule-0000003 and gorule-0000005 dont show up in the reports #2039

pgaudet opened this issue Jul 27, 2023 · 7 comments
Assignees

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Jul 27, 2023

Hello,

gorule-0000003 and gorule-0000005 dont show up in the reports - for example here:
http://release.geneontology.org/2023-06-11/reports/gorule-report.html

image

Note that these are the only 2 'legacy' rules (ie implementing owltools code); is this code not being ran anymore?
Would it be more judicious to rewrite these rules in new framework, or should we try to troubleshoot why these are not being displayed?

@pgaudet
Copy link
Contributor Author

pgaudet commented Aug 31, 2023

  • gorule-0000003 is deprecated (but its status was 'legacy'), gorule-0000003 description is now fixed to indicate it is deprecated, see Update gorule-0000003 #2055
  • Note that the owl reports still return errors for gorule-0000003, so we're not sure that it really is deprecated (it seems like it's still implemented)

@pgaudet
Copy link
Contributor Author

pgaudet commented Aug 31, 2023

gorule-0000005: we still dont know why the error is not showing up in the reports (probably due to being ran be owl-tools)

@mugitty needs to check with @kltm

@kltm
Copy link
Member

kltm commented Sep 1, 2023

owltools output is largely a dead end--those rules need to be re-implemented elsewhere (there are tickets for that).
Otherwise, for non-owltools things missing, one should all check the reports' suppression tags, although that may not be this case.

@mugitty
Copy link
Contributor

mugitty commented Sep 6, 2023

@kltm , According to https://github.com/geneontology/go-site/blob/master/metadata/rules/gorule-0000005.md, this is implemented in owltools. Should this be implemented in ontobio?

@kltm
Copy link
Member

kltm commented Sep 6, 2023

As a matter of fact, there is no real owltools reporting, although rules may "exist" there. Everything that violates a rule should generate a trace, but that is not where we are at at the moment and I'm not sure this is in scope of any current project.

@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 26, 2023

  • gorule-0000003 is deprecated >> OK
  • gorule-0000005 should be re-implemented at some point.
    I'll create a new ticket but for a future project.

@pgaudet pgaudet closed this as completed Sep 26, 2023
@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 26, 2023

Changed status of gorule-0000005 to indicated that its is not implemented (status = approved)
see #2073

@pgaudet pgaudet closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

3 participants