Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work out GPAD output for MF and BP of macromolecular complex members #110

Open
vanaukenk opened this issue May 24, 2017 · 4 comments
Open

Comments

@vanaukenk
Copy link

Hi,

We touched on this issue somewhat in #69 , but I don't think we've quite gotten this sorted out.

The issue here is how individual complex members will be annotated for any associated MF and BP annotations.

I have a simple test model for this here:
http://noctua.berkeleybop.org/editor/graph/gomodel:591f58ab00000003

Right now, in the GPAD, the complex members get a part_of annotation to the CC complex term, but no annotations to the MF enabled by the complex or the associated BP.

We will need to decide if, in the GPAD, the individual members should each get a 'contributes to' qualifier for the MF annotation.

As always, it would probably be worth it to work through a few more examples of macromolecular complexes in Noctua and GO-CAM models to make sure we're satisfied they're being represented properly.

Thanks,
--Kimberly

@balhoff
Copy link
Member

balhoff commented May 25, 2017

Do we want to add a property chain?

part_of o enables -> contributes_to

@vanaukenk
Copy link
Author

That's the idea, but I think we may want to model a few different scenarios to make sure we are getting the representation correct. I'm working on another model containing complexes right now.

@ukemi
Copy link

ukemi commented Feb 22, 2022

Also related to #322

@suzialeksander
Copy link

Discussed on pathways call 5 Dec 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants