Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RNAcentral IDs incorrectly use OBO PURL namespace #100

Closed
balhoff opened this issue May 9, 2022 · 5 comments · Fixed by #101
Closed

RNAcentral IDs incorrectly use OBO PURL namespace #100

balhoff opened this issue May 9, 2022 · 5 comments · Fixed by #101

Comments

@balhoff
Copy link
Member

balhoff commented May 9, 2022

I believe this is the cause of ShEx violations caused by missing root types, noted here:
#99
geneontology/minerva#481

@kltm
Copy link
Member

kltm commented May 9, 2022

@balhoff Regarding #101
What is a positive or negative test we can use to prove that this worked when we go for our next update?

@kltm kltm moved this from Discussion to Working in Ongoing data QC and pipeline maintenance May 9, 2022
@balhoff
Copy link
Member Author

balhoff commented May 10, 2022

@kltm after this change, NEO should no longer contain a term http://purl.obolibrary.org/obo/RNAcentral#_URS000229B2C9_9606. It should now contain a term http://rnacentral.org/rna/URS000229B2C9_9606.

@kltm kltm closed this as completed in #101 May 10, 2022
@kltm
Copy link
Member

kltm commented May 11, 2022

Some browsing on early products seems to essentially confirm that the change is in place:

$ zgrep -a "URS000229B2C9_9606" blazegraph-go-lego-reacto-neo.jnl.gz | grep -a -c purl
0
$ zgrep -a "URS000229B2C9_9606" blazegraph-go-lego-reacto-neo.jnl.gz | grep -a -c rnacentral
1

@kltm kltm moved this from Working to Clearing in Ongoing data QC and pipeline maintenance May 11, 2022
@kltm kltm reopened this May 11, 2022
@kltm
Copy link
Member

kltm commented May 11, 2022

Can close once in production (Thursday, if no incident) so that other issues know to revisit.

@kltm
Copy link
Member

kltm commented Sep 24, 2022

This should be out.

@kltm kltm closed this as completed Sep 24, 2022
@kltm kltm moved this from Clearing to Done in Ongoing data QC and pipeline maintenance Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants