Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo interface/handlers to accept the all-individual model #108

Closed
kltm opened this issue Apr 14, 2015 · 4 comments
Closed

Redo interface/handlers to accept the all-individual model #108

kltm opened this issue Apr 14, 2015 · 4 comments

Comments

@kltm
Copy link
Member

kltm commented Apr 14, 2015

This is dependent on the completion of #76, the more critical backend part.

Redoing the interface to accept the all-individual model is listed separately as other clients do not need to wait for the low-level graph editor to incorporate all the necessary changes before moving forward.

Essentially, the first pass of this is to make the current interface grossly map onto the new model system, mostly by switching from the in-manager methods to the request_set request builder methods and using the manager.request_with() method.

At this point, the interface would be ugly, but consistent and usable by /expert/ users in our already expert pool.

The second level changes are to 1) "intelligently" fold the expanded individual sets into single visual units and 2) make editorial controls usable with this interface. The "exploded interface should still be available as well.

Once this is completed, the ticket is closed and the all-individual model system is ready for general (and expert) consumption.

@kltm kltm added this to the 2015-04-push milestone Apr 14, 2015
@kltm
Copy link
Member Author

kltm commented Apr 15, 2015

Talking with @cmungall, we will mostly likely opt for a single release after the completion of part 2, rather than a rolling release schedule after the completion of part 1.

@kltm kltm changed the title Redo interface to accept the all-individual model Redo interface/handlers to accept the all-individual model Apr 23, 2015
kltm added a commit to berkeleybop/bbopx-js that referenced this issue Apr 28, 2015
@kltm
Copy link
Member Author

kltm commented Apr 28, 2015

We now have the local dev example (gomodel:taxon_559292-5525a0fc0000001 vs gomodel:taxon_559292-5525a0fc0000001_all_indivdual) that renders as expected.

I suspect the best way to handle this is to still create and handle the interface with "edit" nodes and edges (edit.js), but be more clever about their creation, mapping, and event mapping.

Essentially, as a first pass without editing, we just need two paths through the edit node assembler.

@kltm
Copy link
Member Author

kltm commented Apr 30, 2015

This issue is now being addressed as getting the current editor system to work with the "exploded" all-individual models.

kltm added a commit to berkeleybop/bbopx-js that referenced this issue May 1, 2015
kltm added a commit to berkeleybop/bbopx-js that referenced this issue May 1, 2015
kltm added a commit that referenced this issue May 1, 2015
@kltm kltm closed this as completed in 4384ec9 May 1, 2015
@kltm
Copy link
Member Author

kltm commented May 1, 2015

With this milestone, all previous editing is now possible using the old editor with the new API; just ugly and horribly. Onward to #114.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant