Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noctua library chain needs to be fixed / brought up to date #577

Closed
kltm opened this issue Aug 29, 2018 · 2 comments
Closed

Noctua library chain needs to be fixed / brought up to date #577

kltm opened this issue Aug 29, 2018 · 2 comments

Comments

@kltm
Copy link
Member

kltm commented Aug 29, 2018

Currently, some libraries seem to have not been properly transitioned between node 6 and 8, giving errors like:

```
/home/sjcarbon/local/src/git/amigo/javascript/npm/amigo2-instance-data/node_modules/require-dir/index.js:93
        if (!require.extensions.hasOwnProperty(ext)) {
                                ^
TypeError: require.extensions.hasOwnProperty is not a function
```

Some explanation here:
https://stackoverflow.com/questions/44298322/node-8-0-0-and-npm-4-2-0-error-express-load-require-extensions-hasownproperty-is

Closure of this will be a pass of our noctua-oriented libraries and confirming that node 8.11 and npm 5.6 (more-or-less what we've agreed) are all working for tests.

@goodb

@kltm kltm added this to the hotfix milestone Aug 29, 2018
@kltm kltm changed the title Noctua library chaing needs to be fixed / brought up to date Noctua library chain needs to be fixed / brought up to date Aug 31, 2018
kltm added a commit to berkeleybop/minerva-requests that referenced this issue Aug 31, 2018
kltm added a commit to berkeleybop/minerva-requests that referenced this issue Aug 31, 2018
kltm added a commit to berkeleybop/minerva-requests that referenced this issue Aug 31, 2018
@kltm
Copy link
Member Author

kltm commented Aug 31, 2018

Done so far:

  • minerva-requests
  • bbop-response-barista
  • noctua-repl
  • noctua

kltm added a commit to berkeleybop/bbop-response-barista that referenced this issue Aug 31, 2018
kltm added a commit to geneontology/noctua-repl that referenced this issue Aug 31, 2018
@kltm
Copy link
Member Author

kltm commented Aug 31, 2018

Probably others, but this is the main stuff we want working right now.

@kltm kltm closed this as completed Aug 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant