Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some hardcoded relations to graph editor widget #802

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

kltm
Copy link
Member

@kltm kltm commented Nov 8, 2022

Add some additional requested relations to graph editor widget; for #801

@kltm kltm changed the title add some hardcoded rels for #801 add some hardcoded relations to graph editor widget Nov 8, 2022
@kltm
Copy link
Member Author

kltm commented Nov 8, 2022

@vanaukenk I wanted to check that these reflects the changes you wanted.
I'd note that the contents of the free-for-all section comes from the ontology and minerva, so we should look in that direction if there are issues in the lower section.

@vanaukenk
Copy link

Thank you @kltm
I looked at the text of the code updates and it looks okay to me.
Let's update Noctua whenever you have time.

@kltm kltm marked this pull request as ready for review November 16, 2022 19:44
@kltm
Copy link
Member Author

kltm commented Nov 16, 2022

@vanaukenk I've added the changes to noctua-dev (e.g. http://noctua-dev.berkeleybop.org/editor/graph/gomodel:634db72e00000005 ). If this looks okay, I'll merge on master and rebuild. No downtime should be necessary.

@vanaukenk
Copy link

Thanks @kltm
Things look good, except that the labels for 'indirectly negatively regulates' and 'indirectly positively regulates' are still showing in the editor as 'indirectly inhibits' and 'indirectly activates' even though they are correctly labeled in the pop-up window.
Do we need to bring minerva down to fix this bit?

@vanaukenk
Copy link

Hi @kltm

Apologies, I just saw this comment: #801 (comment)

We'll want to have the labels fixed because we need GO-CAM models to use as examples for the documentation.

I'll also comment on the main ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants