Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obographs should distinguish between annotationProperty, objectProperty & dataProperty #65

Closed
Tracked by #101
dosumis opened this issue Apr 6, 2020 · 3 comments

Comments

@dosumis
Copy link

dosumis commented Apr 6, 2020

Current specification for node types
has only:

                "type" : {
                  "type" : "string",
                  "enum" : [ "CLASS", "INDIVIDUAL", "PROPERTY" ]
                },

I guess that changing this enum now to distinguish OP, AP & DP is not possible as it would be a pretty major breaking change. Would it be possible instead to add a property_type key with enum:

["annotationProperty", "objectProperty", "dataProperty"]

?

(I'm sure I requested this several years ago, but not sure where - can't find ticket)

@dosumis
Copy link
Author

dosumis commented Apr 6, 2020

Use case: loading neo4j property graphs to allow subsequent conversion to OWL.

@cmungall
Copy link
Member

cmungall commented May 3, 2023

Notes from call between @julesjacobsen and myself. We agree with the proposal. We will add property_type on Node. This will only be filled if node.type == "PROPERTY".

To be consistent with existing conventions the permissible values should be ANNOTATION, OBJECT, DATA

@julesjacobsen
Copy link
Collaborator

Prefix(:=<http://www.semanticweb.org/matentzn/ontologies/2021/11/untitled-ontology-544#>)
Prefix(owl:=<http://www.w3.org/2002/07/owl#>)
Prefix(rdf:=<http://www.w3.org/1999/02/22-rdf-syntax-ns#>)
Prefix(xml:=<http://www.w3.org/XML/1998/namespace>)
Prefix(xsd:=<http://www.w3.org/2001/XMLSchema#>)
Prefix(rdfs:=<http://www.w3.org/2000/01/rdf-schema#>)

Ontology(<http://www.semanticweb.org/matentzn/ontologies/2021/11/untitled-ontology-544>

  Declaration(Class(<http://purl.obolibrary.org/obo/upheno/workshop2021/TMP_0000059>))
  Declaration(AnnotationProperty(<http://purl.obolibrary.org/obo/upheno/workshop2021/TMP_0000060>))
  Declaration(ObjectProperty(<http://purl.obolibrary.org/obo/upheno/workshop2021/TMP_0000061>))
  Declaration(DataProperty(<http://purl.obolibrary.org/obo/upheno/workshop2021/TMP_0000062>))
)

becomes

---
graphs:
- id: "http://www.semanticweb.org/matentzn/ontologies/2021/11/untitled-ontology-544"
  nodes:
  - id: "http://purl.obolibrary.org/obo/upheno/workshop2021/TMP_0000059"
    type: "CLASS"
  - id: "http://purl.obolibrary.org/obo/upheno/workshop2021/TMP_0000061"
    type: "PROPERTY"
    propertyType: "OBJECT"
  - id: "http://purl.obolibrary.org/obo/upheno/workshop2021/TMP_0000062"
    type: "PROPERTY"
    propertyType: "DATA"
  - id: "http://purl.obolibrary.org/obo/upheno/workshop2021/TMP_0000060"
    type: "PROPERTY"
    propertyType: "ANNOTATION"

julesjacobsen added a commit to julesjacobsen/obographs that referenced this issue May 3, 2023
Change for geneontology#90 - ensure all declared nodes (CLASS, INDIVIDUAL, PROPERTY) are added even if unlabelled.
Change for geneontology#93 - log untranslated axioms to WARN
Update examples/ with changes
Enable obographs-cli to convert ttl to json and yaml
cmungall added a commit to INCATools/ontology-access-kit that referenced this issue May 11, 2023
* Adding property_type node to obograph schema.

See geneontology/obographs#65

* sync code changes

* aligning changes with obographs

* resolving Nico's comment
julesjacobsen added a commit that referenced this issue Nov 8, 2023
Change for #65 - add PropertyType to PROPERTY Nodes
Change for #90 - ensure all declared nodes (CLASS, INDIVIDUAL, PROPERTY) are added even if unlabelled. 
Change for #93 - log untranslated axioms to WARN
Update examples/ with changes
Update schema/ with changes
Enable obographs-cli to convert ttl to json and yaml
Update for #103 - remove Guava dependency from core
Update Junit to Jupiter 5.0.3
Update  version to 0.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants