Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GAR support #135

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Conversation

Alphasite
Copy link
Contributor

This is adding google artifact registry support; i have manually tested it and it appears to work.

❯ ./leftovers-darwin-amd64 --filter bacon --gcp-service-account-key ~/Downloads/GSAK.json -i gcp --type="repository" --debug 
Listing Repositories for region asia-northeast1...
Listing Repositories for region europe-west12...
Listing Repositories for region southamerica-west1...
Listing Repositories for region asia-south2...
Listing Repositories for region asia-southeast2...
Listing Repositories for region europe-west9...
Listing Repositories for region northamerica-northeast1...
Listing Repositories for region us-east5...
Listing Repositories for region asia-northeast2...
Listing Repositories for region asia-northeast3...
Listing Repositories for region us-west2...
Listing Repositories for region asia-east2...
Listing Repositories for region asia-south1...
Listing Repositories for region europe-central2...
Listing Repositories for region us-east1...
Listing Repositories for region us-west3...
Listing Repositories for region asia-east1...
Listing Repositories for region australia-southeast1...
Listing Repositories for region me-central1...
Listing Repositories for region me-west1...
Listing Repositories for region us-east4...
Listing Repositories for region europe-north1...
Listing Repositories for region europe-west2...
Listing Repositories for region europe-west6...
Listing Repositories for region southamerica-east1...
Listing Repositories for region europe-southwest1...
Listing Repositories for region europe-west1...
Listing Repositories for region europe-west8...
Listing Repositories for region us-south1...
Listing Repositories for region us-west1...
Listing Repositories for region asia-southeast1...
Listing Repositories for region australia-southeast2...
Listing Repositories for region europe-west3...
Listing Repositories for region europe-west4...
Listing Repositories for region northamerica-northeast2...
Listing Repositories for region us-central1...
Listing Repositories for region us-west4...
[Artifact Repository: projects/nishadm/locations/us-west2/repositories/bacon-repo] Delete? (y/N): y
[Artifact Repository: projects/nishadm/locations/us-west2/repositories/bacon-repo] Deleting...
[Artifact Repository: projects/nishadm/locations/us-west2/repositories/bacon-repo] Deleted!

And tests pass:

/usr/local/opt/go/libexec/bin/go test -json ./...
{"Time":"2023-05-24T14:31:04.37398-07:00","Action":"start","Package":"github.com/genevieve/leftovers/gcp/artifacts"}
{"Time":"2023-05-24T14:31:04.37421-07:00","Action":"start","Package":"github.com/genevieve/leftovers/gcp/artifacts/fakes"}
?   	github.com/genevieve/leftovers/gcp/artifacts/fakes	[no test files]
=== RUN   TestContainer
Running Suite: gcp/artifact - /Users/nishadm/Workspace/github.com/genevieve/leftovers/gcp/artifacts
===================================================================================================
Random Seed: 1684963864

Will run 8 of 8 specs
••••••••

Ran 8 of 8 Specs in 0.001 seconds
SUCCESS! -- 8 Passed | 0 Failed | 0 Pending | 0 Skipped
--- PASS: TestContainer (0.00s)
PASS
ok  	github.com/genevieve/leftovers/gcp/artifacts	0.298s

Process finished with the exit code 0

@genevieve
Copy link
Owner

Hi @Alphasite, it looks like the go.sum file was deleted in this branch?

@Alphasite
Copy link
Contributor Author

Hi @Alphasite, it looks like the go.sum file was deleted in this branch?

Ah, sorry recreated it and forgot to commit the updated version to git (i was seeing some issues with updating one of the dependencies), should be fixed now.

@genevieve genevieve merged commit 6236b67 into genevieve:main Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants