Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Body_prop=bgcolor not showing on welcome page standard template ? #1266

Open
rpo opened this issue Dec 17, 2021 · 16 comments
Open

Body_prop=bgcolor not showing on welcome page standard template ? #1266

rpo opened this issue Dec 17, 2021 · 16 comments

Comments

@rpo
Copy link

rpo commented Dec 17, 2021 •
edited

Either body_prop=bgcolor or body_prop=background not showing on my welcome page (and others) for the normal template on V7. However it shows on the 'm' template of the same database (same configuration file indeed)!

Standard Welcome page has the correct body%body_prop; and div class="container" call after the head section.

CSS files [/gw/etc] attributes are correctly showing for both templates. CGI mode.

?????
@rpo rpo changed the title What can cause body_prop=bgcolor not showing on welcome page ? Body_prop=bgcolor not showing on welcome page standard template ? Dec 17, 2021
@rpo
Copy link
Author

rpo commented Dec 20, 2021 •
edited

Still unable to get the 'body_prop' property working. However i can have any background i want to my satisfaction using the 'container' - such as div class="container-lg" style="background-color: #F6F6E4; padding-top: 2px; padding-bottom: 5px"
etc.

The division 'container' works ok on any PC for the Welcome page However on portable phones, the class class="d-flex flex-column.." which contain the menus / dictionaries gets out of that container - this has to be fixed ! [not color related although]

@hgouraud
Copy link
Collaborator

I will try to look into it tomorrow!

@hgouraud
Copy link
Collaborator

body_prop=style="background-color:lightblue;"
works fine for me both in daemon and CGI mode!

@rpo
Copy link
Author

rpo commented Dec 21, 2021 •
edited

background-fault

body_prop=style="background-color:lightblue;"

Attribute added to the Welcome.txt page or used into the base.gwf ? - For me neither one works!
Here the result i have (note: container painted): http://genepoulin.net/gene/geneweb7.cgi?b=poulin

Can you send me a copy of your Welcome.txt page ?

@hgouraud
Copy link
Collaborator

hgouraud commented Dec 21, 2021 via email

@rpo
Copy link
Author

rpo commented Dec 21, 2021 via email

@hgouraud
Copy link
Collaborator

https://github.com/geneweb/geneweb/blob/master/plugins/welcome/assets/etc/welcome.txt

@rpo
Copy link
Author

rpo commented Dec 21, 2021 •
edited

Still does'nt show the background !!!!

Earlier you show me this string: body_prop=style="background-color:lightblue;" - where did you get that style ?

Here extract of that welcome page source (it has the background argument coming from the configuration file)
background-fault3

@hgouraud
Copy link
Collaborator

Not sure the parameters bgcolor, text, link are compatible with the bootstrap and the css environment.
In my case, the source of my welcome page is:

<link rel="stylesheet" href="css/bootstrap.min.css?version=4.4.1">
<link rel="stylesheet" href="css/all.min.css?version=5.12.0">
<link rel="stylesheet" href="css/css.css">

<!-- end include css -->

<!-- begin include hed -->
<meta name="format-detection" content="telephone=no" />

<!-- end include hed -->
</head>
<body style="background-color:lightblue;">
<div class="container">
<div class="d-flex flex-column flex-md-row justify-content-lg-center mt-2 mt-lg-4">
<div class="col-xs-12 col-md-auto order-md-3 ml-md-auto px-0">
<div class="d-flex flex-column">

You can augment the style part of body with other values. Examine the content of hd/css/css.css for further ideas.

@hgouraud
Copy link
Collaborator

@a2, you are a much better style expert than myself! Can you comment?

@rpo
Copy link
Author

rpo commented Dec 21, 2021

Personally i now get the background on the welcome page using regular style code such as
body style="; background-color: #C8C892"
div class="container mt-3" style="background-color: #F6F6E4; padding-top: 2px; padding-bottom: 5px"

Maybe the background property on the gwf file got broken at some time - at least for me - and i have tried every welcome.txt version i have, some of them 2 years' old without success (Linux), ... So yes its a real possibility that bootstrap may be in the way !? :-] Thanks

@a2line
Copy link
Collaborator

a2line commented Dec 21, 2021

De mon point d'vue, la fonction est dépréciée comme la balise bgcolor l'est pour HTML5 (elle était déjà obsolète en HTML 4.01). C'est le .gwf généré par défaut qui n'est pas à jour.

@rpo
Copy link
Author

rpo commented Dec 21, 2021

De mon point d'vue, la fonction est dépréciée comme la balise bgcolor l'est pour HTML5 (elle était déjà obsolète en HTML 4.01). C'est le .gwf généré par défaut qui n'est pas à jour.

Et c'est sans doute pour cette raison que dans les dernières versions v7 on a enlevé toute la section bgcolor du fichier demo a.gwf

@hgouraud
Copy link
Collaborator

Ce n'est pas le fichier .gwf par défaut qui est en cause, mais le "configurateur" de .gwf sous gwsetup.
Cette partie est effectivement à revoir!!

@hgouraud
Copy link
Collaborator

je vois le style pour bgcolor ->background-color
Quel est l'équivalent pour text, link et vlink?

@rpo
Copy link
Author

rpo commented Dec 22, 2021 •
edited

je vois le style pour bgcolor ->background-color Quel est l'équivalent pour text, link et vlink?

Edit/ La couleur des liens est donné par .nav.link dans bootstrap.min.css mais c'est selon ce qui est défini par css.txt - et pour moi c'est pas encore clair !

Edit / Par contre le fichier .gwf est effectif pour le background du templste m. Ce sont des conditions différentes dans css.txt et qui ne font pas appel au bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rpo @hgouraud @a2line