Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] plugins scene need a good "revision" #1576

Open
michelmno opened this issue Sep 21, 2023 · 4 comments
Open

[BUG] plugins scene need a good "revision" #1576

michelmno opened this issue Sep 21, 2023 · 4 comments

Comments

@michelmno
Copy link
Contributor

[BUG] why empty Plugins list in welcome page ?

use case:

Capture d’écran du 2023-09-21 08-57-49

git blame command is reporting cid b9fbd74 as source of related change in welcome.txt

$git blame ./hd/etc/welcome.txt
b9fbd74927 (A2              2022-09-06 20:40:37 +0200 285)     %if;(plugins!="")
b9fbd74927 (A2              2022-09-06 20:40:37 +0200 286)       <div class="d-flex flex-column flex-lg-row justify-content-lg-center mt-2 mt-lg-4">
b9fbd74927 (A2              2022-09-06 20:40:37 +0200 287)         <div class="h4 align-self-lg-center mr-lg-2">
b9fbd74927 (A2              2022-09-06 20:40:37 +0200 288)           <i class="fas fa-book fa-sm fa-fw text-secondary mr-1"></i>[*plugins][:]
b9fbd74927 (A2              2022-09-06 20:40:37 +0200 289)           <span class="small">%bvar.plugins;</span>
b9fbd74927 (A2              2022-09-06 20:40:37 +0200 290)         </div>
b9fbd74927 (A2              2022-09-06 20:40:37 +0200 291)       </div>
b9fbd74927 (A2              2022-09-06 20:40:37 +0200 292)     %end;

Multiple questions:

  • As per attached image I have a Plugin information that have no provided list.
    What is the purpose of such empty list ?
  • I suggest to change the test in welcome.txt
    from: %if;(plugins!="")
    to: %if;(plugins!="" & bvar.plugins!='')
  • If plugins defined in gwf file, what is purpose for end user to have this list of supported plugins in the welcome page ? or is it only a debug information ?
  • Is the plugins mechanism something that is still used/usefull for geneweb 7.1beta (cid 59a1e8c)?
  • Would probably need to reconcile the list of plugins in wiki page to match the current list from git tree
from wiki page:
api
base64
carrousel (WIP)
cgl
easy_format
export
forum
gen
gwxjg
jingoo
no_index
piqi
sedlex
v7
v7_im
welcome (WIP)
xmlm
from git tree:
ls geneweb/plugins
cgl
export
fixbase
forum
gwxjg
jingoo
lib_show
no_index
xhtml
michelmno added a commit to michelmno/geneweb that referenced this issue Sep 21, 2023
as reported in issue geneweb#1576

Signed-off-by: Michel Normand <michel_mno@laposte.net>
hgouraud pushed a commit to hgouraud/geneweb that referenced this issue Sep 22, 2023
as reported in issue geneweb#1576

Signed-off-by: Michel Normand <michel_mno@laposte.net>
@hgouraud
Copy link
Collaborator

It is clear that the plugins scene need a good "revision".
Some plugins have been merged back into the main body (v7, v7_im, carrousel).
Some may still be usefull (cgl, forum, export, fixbase, no_index) although their effectiveness needs to be veriified.

@michelmno michelmno changed the title [BUG] why empty Plugins list in welcome page ? [BUG] plugins scene need a good "revision" Sep 22, 2023
@michelmno
Copy link
Contributor Author

after merge of pr #1577 in hgouraud/fix-rl branch, keep open current issue to track futur "revision" of plugins as commented above.

@michelmno michelmno reopened this Oct 16, 2023
a2line pushed a commit to hgouraud/geneweb that referenced this issue Oct 20, 2023
as reported in issue geneweb#1576

Signed-off-by: Michel Normand <michel_mno@laposte.net>
a2line pushed a commit to hgouraud/geneweb that referenced this issue Nov 7, 2023
as reported in issue geneweb#1576

Signed-off-by: Michel Normand <michel_mno@laposte.net>
hgouraud pushed a commit to hgouraud/geneweb that referenced this issue Nov 8, 2023
as reported in issue geneweb#1576

Signed-off-by: Michel Normand <michel_mno@laposte.net>
canonici pushed a commit that referenced this issue Nov 21, 2023
as reported in issue #1576

Signed-off-by: Michel Normand <michel_mno@laposte.net>
@a2line
Copy link
Collaborator

a2line commented Dec 3, 2023

ftrojahn pushed a commit to ftrojahn/geneweb that referenced this issue Dec 3, 2023
as reported in issue geneweb#1576

Signed-off-by: Michel Normand <michel_mno@laposte.net>
@michelmno
Copy link
Contributor Author

FYIO I updated the geneweb wiki https://geneweb.tuxfamily.org/w/index.php?title=plugins&type=revision&diff=4189&oldid=3997ttps://geneweb.tuxfamily.org/wiki/plugins#Geneweb_plugins
with the reduced list of plugins currently supported in source directory https://github.com/geneweb/geneweb/tree/master/plugins
More work required there to complete description of not documented plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants