Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Why "Incorrect Request" when simple search a place ? #1682

Closed
michelmno opened this issue Dec 25, 2023 · 6 comments
Closed

[BUG] Why "Incorrect Request" when simple search a place ? #1682

michelmno opened this issue Dec 25, 2023 · 6 comments

Comments

@michelmno
Copy link
Contributor

Why "Incorrect Request" when simple search a place ?

use case

  • from welcome page, enter Place/Surname page
  • enter 'Lyon' that is place I know to exist in the database
  • the server reply with an "incorrect request" page as attached below

Capture d’écran du 2023-12-25 19-57-57
Capture d’écran du 2023-12-25 20-03-10

Problem do exist in current master branch at cid 024d8c4

@michelmno
Copy link
Contributor Author

I just tried with cid 7ab19e8 head of hgouraud/fallback
There is no more "Incorrect request"

  • But the 'Lyon' search place reports empty page (image 1)
  • while selecting successively from Country to Town (not using search part) do show the related place (image 2)
  • Is the Search key supposed to work ?
    Capture d’écran du 2023-12-27 20-39-41
    Capture d’écran du 2023-12-27 20-42-47

@hgouraud
Copy link
Collaborator

The semantic of the search button needs to be clarified, possibly extended. It acts today more as a filter (as do the bi, ba, ... checkmarks) and filters on the basis of the top most entries in the places.

@hgouraud
Copy link
Collaborator

Looking back at the code, I believe that checking the box "sous-lieux" (sub-places) should find Lyons anywhere in the hierarchy of places derscriptions.

@michelmno
Copy link
Contributor Author

The semantic of the search button needs to be clarified, possibly extended. It acts today more as a filter (as do the bi, ba, ... checkmarks) and filters on the basis of the top most entries in the places.

I understand the limitation, it is OK for me.

@hgouraud
Copy link
Collaborator

Do you find "Lyons" when you tick the "sous-lieux" check-mark?

@michelmno
Copy link
Contributor Author

Do you find "Lyons" when you tick the "sous-lieux" check-mark?

Yes I did, sorry to not have answered in previous comment.

a2line pushed a commit to hgouraud/geneweb that referenced this issue Jan 22, 2024
canonici pushed a commit that referenced this issue Feb 1, 2024
canonici pushed a commit that referenced this issue Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants