[#73183568] dropdowns + [#73270894]buttons-dropdowns #15
Conversation
import docs.min.css
Navs, Navbar, Breadcrumb, Pagination
- add new task "multi-select" to copy files of "Bootstrap Multiselect" plugin - http://davidstutz.github.io/bootstrap-multiselect/
- add code sample for each patterns
- add new dropdown pattern which is combined with input elements
- for this pattern, uses plugins
- Bootstrap Multiselect http://davidstutz.github.io/bootstrap-multiselect/
create new section "Buttons Dropdowns" which contains 4 patterns below: - Single button dropdowns - Split button dropdowns - Sizing - Dropup variation update "_buttons.scss" to tweak sizes of buttons remove unnecessary css file "bootstrap-glyphicons.css"
| 'use strict'; | ||
|
|
||
| $('.change-brand').on('click', 'a', function(e){ | ||
| console.log("hoge") |
There was a problem hiding this comment.
hey no problem at all, this is the all point of PR, to help each other.
Best Regards
Andrea Belvedere | VP of Engineering | gengo.com
On Wed, Jul 9, 2014 at 9:48 AM, Hitoshi K notifications@github.com wrote:
In js/main.js:
'use strict';
$('.change-brand').on('click', 'a', function(e){
- console.log("hoge")
it is not OK.
—
Reply to this email directly or view it on GitHub
https://github.com/gengo/style-guide/pull/15/files#r14689061.
- 'console.log' is only for debug
change 'width' of search box in the dropdowns which uses 3rd party plugin for implementation.
vwxyz
changed the title
…nto 73270894buttons-dropdown
| @@ -53,4 +62,16 @@ | |||
| display: block; | |||
| margin-bottom: 5px; | |||
| } | |||
| .dropdown-header{ | |||
| font-size:10px; | |||
There was a problem hiding this comment.
Small thing but can we add a space after: something like this font-size: 10px;
Also, if there are different places that are using this font size can you add it to https://github.com/gengo/style-guide/blob/master/scss/_variables.scss and reuse the variable 🙇
There was a problem hiding this comment.
Also a space before { in .dropdown-header {.....} 🙇
There was a problem hiding this comment.
ok. I will tweak this in the next commit.
😄
|
Btw, not sure, but if your are not using https://github.com/csscomb/sublime-csscomb then it would be nice if you could use it so we have more consistency in our CSS parameter order, let me know if you have any questions 🙇🙇🙇 |
- _button.scss - _dropdowns.scss - docs.scss
- scss/_buttons.scss - scss/_dropdowns.scss - scss/docs.scss SassBeautify is plugin for sublime text https://sublime.wbond.net/packages/SassBeautify
also format '_variable.scss' by using SassBeautify
'$dropdown-border-radius' is used in '_dropdown.scss'
- change indent level from '4' spaces to '2' spaces - scss/_buttons.scss - scss/_dropdowns.scss - scss/docs.scss
fix 3 conflicts in merge with master - scss/_dropdowns.scss - scss/_buttons.scss - Gruntfile.coffee
modify 3 scss files - scss/_buttons.scss - scss/_dropdowns.scss - scss/docs.scss
|
LGTM 😎 |
|
LGTM! |
[#73183568] dropdowns + [#73270894]buttons-dropdowns
in dropdowns