-
-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics.history array is broken #228
Comments
It looks like there was a recent change to how the historyValues array is defined. I don't know that this is the issue for sure, but it certainly is suspicious to me. e34249b#diff-d92ebc3e06276c231a9e2cfbb19fb07cL47 I see that the initialization is performed a few lines down, but for some reason historyValues array only contains one value for me. |
I built a test program to see if timers work at all using DateTime.Now and TimeSpan functions with a simple 1 minute offset. That still functions. The Advanced Smart Lights code doesn't do anything more complicated other than storing the timestamp in a module parameter and utilizing the HistoryValue array. Since I've looked at the parameter value and can confirm that it's set to a value that seems appropriate and I have seen that the values within HistoryValue above element 0 do not exist, I believe I have narrowed this down. However, I have no way to fix it. I guess I'll just migrate back to r493 or earlier so that I can get my system working. It looks like there are a number of people using my APP as well, so I'll recommend in that thread that they migrate back/don't update until a resolution is found. |
I'm having a similar problem which may be related - LastOn and LastOff values do not seem to work correctly. For example, if I turn a device on, then off, then on again (in code or interface), the values for LastOn and LastOff do not update correctly, and instead give old values. |
- Enhanced parameter statistics now holding up to 1 day of history (HistoryLimit is now expressed in minutes) - Fixed duplicated event raising causing also issues with History/Statistics (#228) - Added new API command /api/HomeAutomation.HomeGenie/Config/Modules.StatisticsGet/<domain>/<address>/<parameter> - Added new API command /api/HomeAutomation.HomeGenie/Config/Modules.ParameterGet/<domain>/<address>/<parameter> (should close issue #206) - Optimized SSE
please try r497 hope it is fixed now! |
oh-oh... it still needs a little fix... gonna do now |
it's fixed now. for testing you can try calling the new API command
eg.
|
I'm away from my system but will update tomorrow or Monday. If a web update were released, I could try this afternoon. |
a web update will be available as soon as the latest release can be considered stable (almost :)). |
It work fine on my side on 1.1 r497. |
My house lost power and the IP must have changed. My IP change notification APP doesn't email anymore, so I'll have to update when I get home and find the new IP. |
Looks like the fix worked for the Advanced Smart Lights APP. |
good, close the issue if your testing is complete and positive. |
I have an issue with severe lag on my setup that is likely unrelated. I will do some testing to verify that it is unrelated to the HG update. I believe it is related to a power failure that may have caused a module or other electronic to go bad. I will close the issue when I confirm it is not related to HG. |
I confirmed that the code works. My issue with large delays seems to be unrelated. Issue closed. |
As reported in this thread:
http://www.homegenie.it/forum/index.php?topic=1101.0
The history array only holds the first element and all others seem to be invalid. HistoryLimit is not set other than by default.
The text was updated successfully, but these errors were encountered: