Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qoost: missing port not always detected #2189

Closed
cproc opened this issue Dec 2, 2016 · 1 comment
Closed

qoost: missing port not always detected #2189

cproc opened this issue Dec 2, 2016 · 1 comment
Assignees

Comments

@cproc
Copy link
Member

cproc commented Dec 2, 2016

Missing ports are only detected if select_from_ports is called for that port. For qoost, this is done in 'import-qoost.mk', but this file is not included if qoost is a dependency of a library (for example qt5_qpa_nitpicker) instead of a program.

@cproc cproc added the bug label Dec 2, 2016
@cproc cproc self-assigned this Dec 2, 2016
@cproc
Copy link
Member Author

cproc commented Dec 2, 2016

When adding 'qoost' to the 'LIBS' variable in 'repos/base/src/test/log/target.mk', the missing port is also not detected, even though 'import-qoost.mk' gets included. So the problem is not really related to qoost being a dependency of a library instead of a program.

cproc added a commit to cproc/genode that referenced this issue Dec 2, 2016
'select_from_ports' must be called to detect a missing port.

Fixes genodelabs#2189
@cproc cproc added fixed and removed fixed labels Dec 2, 2016
cproc added a commit to cproc/genode that referenced this issue Dec 2, 2016
'select_from_ports' must be called to detect a missing port.

Fixes genodelabs#2189
@cproc cproc added the fixed label Dec 2, 2016
chelmuth pushed a commit that referenced this issue Dec 7, 2016
'select_from_ports' must be called to detect a missing port.

Fixes #2189
@nfeske nfeske closed this as completed in 5a72738 Dec 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant