Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove http_block, block_cache, and test/block #4405

Closed
nfeske opened this issue Feb 4, 2022 · 2 comments
Closed

Remove http_block, block_cache, and test/block #4405

nfeske opened this issue Feb 4, 2022 · 2 comments

Comments

@nfeske
Copy link
Member

nfeske commented Feb 4, 2022

Those components rely on the old block/component.h framework classes, which have long been superseded by the Block::Request_stream. In order to dispose the legacy block/component.h API, those components would need to be updated. However, given that they are lingering unused since years, I doubt that the effort is justified.

Should the functionality become needed, we would probably want to implement those features differently, anyway. E.g., supporting SSL for accessing a block device over HTTP, or implementing a block cache as VFS plugin instead of a bump-in-the-wire server. So I don't see a revival of the existing components very likely.

I presume that test/block has been superseded by app/block_tester and vfs_block in the meantime.

@skalk and @cnuke, what is your opinion?

@nfeske nfeske added the cleanup label Feb 4, 2022
@cnuke
Copy link
Member

cnuke commented Feb 4, 2022

@nfeske I am fine with removing them.

nfeske added a commit that referenced this issue Feb 4, 2022
nfeske added a commit that referenced this issue Feb 4, 2022
nfeske added a commit that referenced this issue Feb 4, 2022
nfeske added a commit that referenced this issue Feb 4, 2022
The functionality of the test-block-client, test-block-server, and
test-block-bench components is now covered by the block_tester
application and the vfs_block server.

Issue #4405
@nfeske nfeske added the fixed label Feb 11, 2022
nfeske added a commit that referenced this issue Feb 15, 2022
nfeske added a commit that referenced this issue Feb 15, 2022
nfeske added a commit that referenced this issue Feb 15, 2022
nfeske added a commit that referenced this issue Feb 15, 2022
The functionality of the test-block-client, test-block-server, and
test-block-bench components is now covered by the block_tester
application and the vfs_block server.

Issue #4405
@nfeske
Copy link
Member Author

nfeske commented Feb 15, 2022

Fixed in master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants