Set SSG Test Names #1687
Merged
Set SSG Test Names #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jasonwalker80
commented
Mar 24, 2017
jasonwalker80
commented
- a command to set test names on all SSG results (excluding aligner index, etc.)
- wait to abandon builds until we have a complete list and test names are set
ebelter
approved these changes
Mar 24, 2017
tmooney
reviewed
Mar 28, 2017
| }, | ||
| abandon_builds => { | ||
| is => 'Boolean', | ||
| doc => 'attempt to abando all of the builds used by these results', |
| my @results_to_set_test_name; | ||
| for my $build ( $self->builds ) { | ||
| my @results = $build->results; | ||
| push @results_to_set_test_name, grep { $result_classes_to_set_test_name->{$_->class} } @results; |
There was a problem hiding this comment.
The database/UR can do this restriction for us, e.g.:
$build->results(subclass_name => [
'Genome::Qc::Result',
'Genome::InstrumentData::AlignmentResult::Speedseq',
'Genome::InstrumentData::AlignmentResult::Merged::Speedseq',
'Genome::Model::SingleSampleGenotype::Result::HaplotypeCaller'
]);…turned when evaluating storage or software results that require a test name when invalidating a build.
|
@tmooney will the latest commit work for "whitelisting" result classes? |
tmooney
approved these changes
Mar 28, 2017
tmooney
reviewed
Mar 28, 2017
| my $abandon_cmd = Genome::Model::Build::Command::Abandon->create( | ||
| builds => \@builds, | ||
| header_text => 'Build Abandoned - SR Test Name', | ||
| body_text => 'Software result '. $software_result->id .' has new test name '. $self->new_test_name, |
There was a problem hiding this comment.
With this pulled out of the loop $software_result is no longer available.
|
Yes, the intent is to eventually define |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.