Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

logging content improvements #13

Merged
merged 3 commits into from
Jan 28, 2015
Merged

logging content improvements #13

merged 3 commits into from
Jan 28, 2015

Conversation

davidlmorton
Copy link
Contributor

The Response.get_data() function wasn't giving us the whole data, but a
list of keys in the data like so:

now

DEBUG [ptero_workflow.api.v1.views]     Returning: ( { 'begins': [0],
    'color': 0,
    'colors': [0],
    'data': { u'petri_response_links': ...
    'inputs': { u'param': u'foo'},
    'method': { 'name': u'execute',
                'service': u'shell-command',
                'task': { 'name': u'C', 'type': u'method-list'}},
    'outputs': { u'param': u'foo'},
    'parent_color': None,
    'status': u'begun',
    'status_history': [ { 'status': u'begun',
                          'timestamp': '2015-01-28 01:07:18'}]},
  200)

was

DEBUG [ptero_workflow.api.v1.views]     Body: 'beginscolorcolorsdatainputsmethodoutputsparent_colorstatusstatus_history'

which is not helpful.

The Response.get_data() function wasn't giving us the whole data, but a
list of keys in the data like so:

now

    DEBUG [ptero_workflow.api.v1.views]     Returning: ( { 'begins': [0],
        'color': 0,
        'colors': [0],
        'data': { u'petri_response_links': ...
        'inputs': { u'param': u'foo'},
        'method': { 'name': u'execute',
                    'service': u'shell-command',
                    'task': { 'name': u'C', 'type': u'method-list'}},
        'outputs': { u'param': u'foo'},
        'parent_color': None,
        'status': u'begun',
        'status_history': [ { 'status': u'begun',
                              'timestamp': '2015-01-28 01:07:18'}]},
      200)

was

    DEBUG [ptero_workflow.api.v1.views]     Body: 'beginscolorcolorsdatainputsmethodoutputsparent_colorstatusstatus_history'

which is not helpful.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 4.67% when pulling 6c0693c on davidlmorton:no_response into 78d2104 on genome:master.

@davidlmorton davidlmorton changed the title log what we return instead of Response.get_data() logging content improvements Jan 28, 2015
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 4.69% when pulling f926407 on davidlmorton:no_response into 78d2104 on genome:master.

davidlmorton added a commit that referenced this pull request Jan 28, 2015
@davidlmorton davidlmorton merged commit b15db23 into genome:master Jan 28, 2015
@davidlmorton davidlmorton deleted the no_response branch January 28, 2015 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants