This repository has been archived by the owner on Jan 31, 2020. It is now read-only.
Use getattr() to get _cached_data from request #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Lets pformat on the line where we save 'cached_data' that way it always looks readable. |
|
Good idea. |
mkiwala
force-pushed
the
cached_data_logging
branch
from
84b5ff9
to
5bf6619
Compare
mkiwala
added a commit
that referenced
this pull request
Aug 27, 2015
Use getattr() to get _cached_data from request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids accessing the _cached_data when it does not exist.
The bug wasn't caught by our tests because there are no negative tests for our logged_response wrapper.