Skip to content
This repository has been archived by the owner on Jan 31, 2020. It is now read-only.

Add support for parallel by DAGs #35

Merged
merged 3 commits into from
Oct 21, 2014
Merged

Add support for parallel by DAGs #35

merged 3 commits into from
Oct 21, 2014

Conversation

mark-burnett
Copy link
Contributor

This will not yet work for nested parallel by, because we need to split up the inputs as part of the split, the way we join outputs with the join code and not inside the input connector code.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.54%) when pulling 9a568cc on mark-burnett:parallel-nested-dag into 9f2dcad on genome:dsl-update.

@davidlmorton
Copy link
Contributor

+1 after the minor things I commented on.

I agree that we're going to need to have the task that "splits" on a parallelBy save some pointers to its inputs instead of trying to have the input_connector do it. Will the input_connector still need to make some pointers? I think it can just ask its task for inputs, once dags are Methods.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.55%) when pulling f9bcacf on mark-burnett:parallel-nested-dag into 9f2dcad on genome:dsl-update.

mark-burnett added a commit that referenced this pull request Oct 21, 2014
@mark-burnett mark-burnett merged commit c3b94db into genome:dsl-update Oct 21, 2014
@mark-burnett mark-burnett deleted the parallel-nested-dag branch October 21, 2014 13:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants