Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't see the table sorting controls on the docs pages #47

Closed
turbomam opened this issue Oct 3, 2023 · 4 comments
Closed

I don't see the table sorting controls on the docs pages #47

turbomam opened this issue Oct 3, 2023 · 4 comments
Assignees

Comments

@turbomam
Copy link
Member

turbomam commented Oct 3, 2023

I think this is OK on my local machine now. Trying to rebuild into GH pages now.

@turbomam turbomam self-assigned this Oct 3, 2023
@turbomam
Copy link
Member Author

turbomam commented Oct 3, 2023

Sort controls still don't appear on GH pages

this repo does not use the same GH pages deployment strategy that many other LinkML repos use

@turbomam
Copy link
Member Author

turbomam commented Oct 4, 2023

the table sorting scripts are in mixs-docs-md/javascripts/tablesort.js, but mixs-docs-md/ is one of the directories that is purged by make squeaky-clean

we could stage it somewhere else and copy it (with automation) as needed

@turbomam
Copy link
Member Author

turbomam commented Oct 4, 2023

@sujaypatil96 is this all there is to that file?

document$.subscribe(function() {
    var tables = document.querySelectorAll("article table:not([class])")
    tables.forEach(function(table) {
      new Tablesort(table)
    })
  })

@turbomam turbomam assigned sujaypatil96 and unassigned turbomam Oct 4, 2023
@turbomam
Copy link
Member Author

turbomam commented Oct 4, 2023

moved into src/js-staging/tablesort.js, but without any copying code in the makefile yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants