Support for HTTPS protocol

[osallou]

Biomaj should handle https and directhttps protocols

[osallou]

Following in biomaj/workflow.py should do the job:

...
if protocol == 'http' or protocol == 'https:
    downloader = HTTPDownload(protocol, server, remote_dir, self.bank.config)
if protocol == 'local':
    downloader = LocalDownload(remote_dir)
if protocol == 'directftp':
    downloader = DirectFTPDownload('ftp', server, remote_dir, list_file)
if protocol == 'directhttp':
    downloader = DirectHttpDownload('http', server, remote_dir, list_file)
if protocol == 'directhttps':
    downloader = DirectHttpDownload('https', server, remote_dir, list_file)
...

in bank property files, should use protocol https or directhttps

[osallou]

http and directhttp should also handle CURLOPT_FOLLOWLOCATION to follow redirection when possible.

[horkko]

That should be the reason why after code modification and protocol=directhttps or https the problem still remains?

[osallou]

nope, managing redirects is only a helper.

After setting direchttps in protocol, and

if protocol == 'directhttps':
    logging.debug('Using directhttps protocol')
    downloader = DirectHttpDownload('https', server, remote_dir, list_file)

in workflow.py, is something downloaded ? (the html file was because you tried to reach http instead of https).

Can you also add the logging message above, just to be sure you reach the correct block ?

[horkko]

Check pull request #56

[osallou]

Add unit tests with https://httpbin.org/