Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency on python3-future #134

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Conversation

a-detiste
Copy link
Contributor

python3-future is being removed from Debian

@osallou
Copy link
Contributor

osallou commented Dec 13, 2023

@abretaud vous gerez? Faut merger ,maj version ds setup.py)) et tagger. Ideallement faut apres pusher vers pypi (a voir pour donner les droits sur pypi)

@abretaud
Copy link
Member

Yep we'll look into it with @mboudet, I've received the notification

@a-detiste
Copy link
Contributor Author

Ping.

Bonne Année

biomaj/session.py Outdated Show resolved Hide resolved
@mboudet
Copy link
Member

mboudet commented Jan 8, 2024

Hello,

Thanks for the PR, seems fine to me.
When I was trying to test it, I was unable to install biomaj on a <3.8 version of python (due to dependencies issues), so we'll probably need require at least python 3.8 for this release.

@a-detiste
Copy link
Contributor Author

a-detiste commented Jan 8, 2024 via email

@mboudet
Copy link
Member

mboudet commented Jan 8, 2024

Yes, seems like the solver ignores the 'python_requires' version when installing deps, so we end up with >3.8 requirements even on <3.8 python version (like redis)

@mboudet
Copy link
Member

mboudet commented Jan 8, 2024

Seems like juste using 'pip install' instead of 'python setup.py' fixes the deps issues. Will update the documentation

@osallou
Copy link
Contributor

osallou commented Jan 8, 2024

Deps are defined in setup.py and requirement.txt

@mboudet
Copy link
Member

mboudet commented Jan 8, 2024

Deps are defined in setup.py and requirement.txt

Yes, but installing with a 'python setup.py install' seems to ignore python version when getting the deps.
'pip install' works fine.

(Nothing to fix, just updating doc on this part).

@mboudet
Copy link
Member

mboudet commented Jan 8, 2024

Merging, I'll make a release after a bit of cleanup. Thank your for the PR.

@mboudet mboudet merged commit a7ce930 into genouest:master Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants