Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction generalizing #1229

Merged
merged 8 commits into from
Sep 28, 2021
Merged

Transaction generalizing #1229

merged 8 commits into from
Sep 28, 2021

Conversation

plyhun
Copy link
Contributor

@plyhun plyhun commented Aug 18, 2021

Abstract

Tx entity is widely used in the common code, so has to be generalized into the MDM API as well.

Actions performed:

  1. Tx split into general Tx and GraphDBTx. Tx went into mdm-api.
  2. DAOAction classes went into mdm-api.
  3. BaseTransaction class split into BaseTransaction and GraphDBBaseTransaction. BaseTransaction went into mdm-api.
  4. DAOCollection now references *DAOs, not *DAOWrappers. DAOCollection went into mdm-api.
  5. All the references to DAOWrappers replaced with ones to DAOs where possible. Otherwise a classcast is used, which will be removed after the field containers are split.

Checklist

General

  • Added abstract that describes the change
  • Added changelog entry to /CHANGELOG.adoc
  • Ensured that the change is covered by tests
  • Ensured that the change is documented in the docs

On API Changes

  • Checked if the changes are breaking or not
  • Added GraphQL API if applicable
  • Added Elasticsearch mapping if applicable

@plyhun plyhun added this to the 2.0.0 milestone Aug 18, 2021
@plyhun plyhun requested a review from npomaroli August 18, 2021 11:02
@plyhun plyhun self-assigned this Aug 18, 2021
Base automatically changed from mdm-development-cl-696-tests to mdm-development September 28, 2021 08:27
@plyhun plyhun merged commit 47017fe into mdm-development Sep 28, 2021
@plyhun plyhun deleted the mdm-development-cl-697-tx branch September 28, 2021 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants