mayavi-4.4.0.ebuild tested to build with vtk-6 #349
Conversation
| @@ -0,0 +1,76 @@ | |||
| # Copyright 1999-2013 Gentoo Foundation | |||
There was a problem hiding this comment.
repoman should have alerted you that this is 2015. Did you use repoman?
| test? ( | ||
| ${RDEPEND} | ||
| dev-python/nose[${PYTHON_USEDEP}] | ||
| dev-python/wxpython[opengl] |
There was a problem hiding this comment.
Missing SLOT and PYTHON_USEDEP
There was a problem hiding this comment.
Eh? It seems to work with 2.8, but I'm not sure if it cannot work with 2.9 or 3.0. Right now I'm also too short of time to test this.
Regarding PYTHON_USEDEP, would `dev-python/wxpython[opengl,${PYTHON_USEDEP}] be the right answer to this riddle?
There was a problem hiding this comment.
Well I suggest to add slot 2.8 if it works, but you're right the mayavi ebuils in tree do not specify a slot of wxpython either. @jlec?
Yes, specifying [opengl,${PYTHON_USEDEP}] is correct.
|
Where is the |
|
/usr/portage/sci-visualization/mayavi/ChangeLog As I only ~versionbumped the mayavi-4.3 from the main portage tree all those QA issues apply there as well. |
|
Please add a ChangeLog to the science overlay too. This should contain the changes regarding the version bumped ebuild. Everthing in /usr/portage/sci-visualization/mayavi/ChangeLog isn't needed. Unfortunately not every ebuild in the tree is free of QA issues. Anyway, we shouldn't push them uncleaned to the overlay. Therefore these QA issues need to be fixed. |
|
|
||
| *mayavi-4.4.0 (22 Jan 2015) | ||
|
|
||
| 22 Jan 2015; Justin Lecher <jlec@gentoo.org> +mayavi-4.4.0.ebuild: |
There was a problem hiding this comment.
Please remove @jlec from the ChangeLog and put yourself in.
|
No time for these games, CU. |
|
@jamasi: Could you please explain me what the problem with running |
|
Sorry for this loss of patience. I'm a little pressed to get mayavi back to working as a project of mine depends on it. I just thought to share the ebuild. So obviously I didn't read the current manual, but worked from memory. Now the procedure to contribute seems to have been highly formalised. A reminder to check the relevant docs right at the start of this or to simply adopt the ebuild would have been nice. Esp. as I cannot spare the time to maintain this package properly. (Also I was rather surprised that an ebuild from the main portage tree would not be of acceptable quality.) |
I've quickly tested mayavi after build and it seems to be working.