clang profiles: fix can't create stage1, and cleanup #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,3 +6,6 @@ CFLAGS="-O2 -pipe" | |||
| CXXFLAGS="-stdlib=libc++ ${CFLAGS}" | |||
| FFLAGS="${CFLAGS}" | |||
| FCFLAGS="${CFLAGS}" | |||
|
|
|||
| # sys-devel/clang require static-analyzer, bug 539858 | |||
| BOOTSTRAP_USE="${BOOTSTRAP_USE} static-analyzer" | |||
There was a problem hiding this comment.
Why BOOTSTRAP_USE? Wouldn't it be better to just package.use.force it on LLVM, like you do for clang?
There was a problem hiding this comment.
I used it because it was a problem of stage1.
sys-devel/llvm is enabled static-analyzer by default.
However, it is disabled by USE="-*" when making stage1.
Please comment in bugzilla. Might get a more detailed comments by aballier.
There was a problem hiding this comment.
Ping? I'm still waiting for reply there :P.
|
Merged, thanks. |
minaco2
pushed a commit
to git-portage/git-portage
that referenced
this pull request
Mar 15, 2015
…eanup packages.build. gentoo/gentoo-portage-rsync-mirror#45 by nigoro.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details, please see https://bugs.gentoo.org/show_bug.cgi?id=539858