Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Signed-off-by: Jason Zaman <perfinion@gentoo.org>
- Loading branch information
Signed-off-by: Jason Zaman <perfinion@gentoo.org>
1c9f318There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @perfinion.
Question, why is bazel's version hardcoded to 5.*?
1c9f318#diff-b965508b84c2f4e8306ef774ad91f1344489691be9dfe588b43c99e9bb45c357R145
Won't this the cause a similar build failure regarding the latest stable JDK version? As seen in here: (This issue was solved with the latest bazel version)
bazelbuild/bazel#17103
Thanks in advance! And thank you for all your work!
1c9f318There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh hmmm, that's a good point, forgot about the JDK. It is pinned to bazel-5 because there were some issues building with bazel-6. TF hasn't updated to bazel 6 yet, I will find out at our next SIG-Build meeting about the the timeline for that. I wanted to get this ebuild bump out tho because the previous was missing python3_11 and that was causing problems. 2.13 is out soon so I'll hopefully I can flip some incompatible flags and make it work with bazel-6
1c9f318There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thank you for all of your work!
I'll stay updated