Skip to content

Commit

Permalink
dev-python/pebble: increase attempts for broken test on slow CPU
Browse files Browse the repository at this point in the history
On very slow machines, test_process_pool_stop_stopped_callback fails due
to not raising a RuntimeError. Increasing the number of long_function
instances added to the pool causes it to perform as expected.

See: noxdafox/pebble#112
Bug: https://bugs.gentoo.org/831219
Signed-off-by: Matoro Mahri <matoro@users.noreply.github.com>
Closes: #29709
Signed-off-by: Sam James <sam@gentoo.org>
  • Loading branch information
matoro authored and thesamesam committed Feb 22, 2023
1 parent 82564c2 commit 5f619b9
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 0 deletions.
28 changes: 28 additions & 0 deletions dev-python/pebble/files/pebble-5.0.3-backport-pr112.patch
@@ -0,0 +1,28 @@
https://bugs.gentoo.org/831219
https://github.com/noxdafox/pebble/pull/112

From cd78923ac2a3de7e2ce248734f10170bf516f5b4 Mon Sep 17 00:00:00 2001
From: matoro <matoro@users.noreply.github.com>
Date: Sun, 19 Feb 2023 13:36:34 -0500
Subject: [PATCH] increase attempts for test_process_pool_stop_stopped_callback

On very slow machines, test_process_pool_stop_stopped_callback fails due
to not raising a RuntimeError. Increasing the number of long_function
instances added to the pool causes it to perform as expected.
---
test/test_process_pool_spawn.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test_process_pool_spawn.py b/test/test_process_pool_spawn.py
index f839b0a..d734bdf 100644
--- a/test/test_process_pool_spawn.py
+++ b/test/test_process_pool_spawn.py
@@ -315,7 +315,7 @@ def stop_pool_callback(_):
future = pool.schedule(function, args=[1])
future.add_done_callback(stop_pool_callback)
with self.assertRaises(RuntimeError):
- for index in range(10):
+ for index in range(30):
time.sleep(0.1)
pool.schedule(long_function, args=[index])

1 change: 1 addition & 0 deletions dev-python/pebble/pebble-5.0.3.ebuild
Expand Up @@ -21,5 +21,6 @@ S=${WORKDIR}/${P^}
LICENSE="LGPL-3+"
SLOT="0"
KEYWORDS="~alpha amd64 arm arm64 hppa ~ia64 ~m68k ppc ppc64 ~riscv ~s390 sparc x86"
PATCHES=( "${FILESDIR}/pebble-5.0.3-backport-pr112.patch" )

distutils_enable_tests pytest

0 comments on commit 5f619b9

Please sign in to comment.