media-gfx/alembic: bump to version 1.7.9 #10003

waebbl · 2018-09-28T14:38:38Z

add experimental support for arnold, maya and renderman plugins

Bug: https://bugs.gentoo.org/667230
Signed-off-by: Bernd Waibel waebbl@gmail.com
Package-Manager: Portage-2.3.49, Repoman-2.3.10

gentoo-bot · 2018-09-28T14:40:13Z

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: media-gfx/alembic

media-gfx/alembic: @waebbl, @gentoo/proxy-maint

Linked bugs

Bugs linked: 667230

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

waebbl · 2018-09-28T21:18:59Z

fixed a typo in metadata.xml in pyalembic flag. The restrict attribute is valid for <media-gfx/alembic-1.7.9 not >media-gfx/alembic-1.7.9

waebbl · 2018-09-30T15:40:54Z

Fixed an issue with the python module not importing correctly.

a17r · 2018-09-30T21:20:58Z

media-gfx/alembic/alembic-1.7.9.ebuild

+
+inherit cmake-utils python-single-r1
+
+DESCRIPTION="Alembic is an open framework for storing and sharing scene data"


DESCRIPTION shall not repeat PN. Just start with Open...

a17r · 2018-09-30T21:21:05Z

media-gfx/alembic/alembic-1.7.9.ebuild

+inherit cmake-utils python-single-r1
+
+DESCRIPTION="Alembic is an open framework for storing and sharing scene data"
+HOMEPAGE="http://alembic.io/"


how about https?

does not work for alembic.io, but for www.alembic.io. Changed it.

a17r · 2018-09-30T21:22:42Z

media-gfx/alembic/alembic-1.7.9.ebuild

+	python? ( boost )
+"
+
+CDEPEND="


Single-letter prefix for DEPEND is reserved for future EAPIs. But it is not even required in this case, just make it RDEPEND and make DEPEND inherit that.

Didn't know about the single letter prefixes. Initially I thought I will have more differences, so an extra COMMON_DEPEND would be meaningful, but this isn't actually the case. I changed it.

a17r · 2018-09-30T21:23:32Z

media-gfx/alembic/alembic-1.7.9.ebuild

+
+CDEPEND="
+	${PYTHON_DEPS}
+	>=media-libs/openexr-2.2.0-r2


this will likely need a rebuild on subslot bump, so please add :=

a17r · 2018-09-30T21:23:35Z

media-gfx/alembic/alembic-1.7.9.ebuild

+CDEPEND="
+	${PYTHON_DEPS}
+	>=media-libs/openexr-2.2.0-r2
+	boost? ( >=dev-libs/boost-1.65.0[python,${PYTHON_USEDEP}] )


this will likely need a rebuild on subslot bump, so please add :=

a17r · 2018-09-30T21:30:08Z

media-gfx/alembic/metadata.xml

 	<flag name="hdf5">Add support <pkg>sci-libs/hdf5</pkg></flag>
-	<flag name="pyalembic">Build pyalembic python bindings (needs <pkg>dev-python/pyilmbase</pkg>)</flag>
+	<flag name="maya" restrict="&gt;=media-gfx/alembic-1.7.9">


same as above

a17r · 2018-09-30T21:30:12Z

media-gfx/alembic/metadata.xml

+	<flag name="maya" restrict="&gt;=media-gfx/alembic-1.7.9">
+		Compile Alembic plugin for Maya (experimental)
+	</flag>
+	<flag name="prman" restrict="&gt;=media-gfx/alembic-1.7.9">


same as above

a17r · 2018-09-30T21:30:17Z

media-gfx/alembic/metadata.xml

+	<flag name="prman" restrict="&gt;=media-gfx/alembic-1.7.9">
+		Compile Alembic plugin for Renderman (experimental)
+	</flag>
+	<flag name="pyalembic" restrict="&lt;media-gfx/alembic-1.7.9">


same as above

So with this one and the next one (pyalembic and python use flags) hasn't the meaning actually changed by renaming the first into the latter?

a17r · 2018-09-30T21:30:20Z

media-gfx/alembic/metadata.xml

+		<!-- renamed to python in 1.7.9 -->
+		Build pyalembic python bindings (needs <pkg>dev-python/pyilmbase</pkg>)
+	</flag>
+	<flag name="python" restrict="&gt;=media-gfx/alembic-1.7.9">


same as above

media-gfx/alembic/alembic-1.7.9.ebuild

waebbl

Requested changes are done

a17r

  Manually-specified variables were not used by the project:

    PYILMBASE_ROOT

a17r · 2018-10-01T17:18:59Z

media-gfx/alembic/alembic-1.7.9.ebuild

+src_install() {
+	cmake-utils_src_install
+	if use doc; then
+		dodoc -r "doc/html"


use doc && local HTML_DOCS=( doc/html/. ) and put it before cmake-utils_src_install

waebbl · 2018-10-01T19:01:19Z

Passing the PYILMBASE_ROOT to cmake-utils_src_configure was the easy way without the need to patch one of the CMakefiles. Where did this warning show up? At my last ebuild run, I didn't notice it.

@a17r Please try again. I removed the -DPYILMBASE_ROOT from src_configure and patched the cmake file instead to pass the correct path.

add experimental support for arnold, maya and renderman plugins fix import error in python Bug: https://bugs.gentoo.org/667230 Signed-off-by: Bernd Waibel <waebbl@gmail.com> Package-Manager: Portage-2.3.49, Repoman-2.3.10

gentoo-repo-qa-bot · 2018-10-01T20:15:45Z

Pull request CI report

Report generated at: 2018-10-01 20:15 UTC
Newest commit scanned: 79475ea
Status: ✅ good

No issues found

a17r · 2018-10-03T15:50:11Z

Thanks!

waebbl · 2018-10-03T15:57:53Z

Thanks for approving :)

gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Sep 28, 2018

waebbl force-pushed the alembix-update branch from 42ddb53 to ae0e1de Compare September 28, 2018 21:16

waebbl force-pushed the alembix-update branch 2 times, most recently from dad8a85 to a3b1500 Compare September 30, 2018 15:38

a17r suggested changes Sep 30, 2018

View reviewed changes

waebbl force-pushed the alembix-update branch 3 times, most recently from 199c790 to 7f7ac61 Compare October 1, 2018 06:35

waebbl commented Oct 1, 2018

View reviewed changes

a17r suggested changes Oct 1, 2018

View reviewed changes

waebbl force-pushed the alembix-update branch from 7f7ac61 to 8b9386e Compare October 1, 2018 18:53

media-gfx/alembic: bump to version 1.7.9

79475ea

add experimental support for arnold, maya and renderman plugins fix import error in python Bug: https://bugs.gentoo.org/667230 Signed-off-by: Bernd Waibel <waebbl@gmail.com> Package-Manager: Portage-2.3.49, Repoman-2.3.10

waebbl force-pushed the alembix-update branch from 8b9386e to 79475ea Compare October 1, 2018 19:27

a17r approved these changes Oct 3, 2018

View reviewed changes

gentoo-bot closed this in 162768a Oct 3, 2018

waebbl deleted the alembix-update branch October 3, 2018 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

media-gfx/alembic: bump to version 1.7.9 #10003

media-gfx/alembic: bump to version 1.7.9 #10003

waebbl commented Sep 28, 2018

gentoo-bot commented Sep 28, 2018

waebbl commented Sep 28, 2018

waebbl commented Sep 30, 2018

a17r Sep 30, 2018

a17r Sep 30, 2018

waebbl Oct 1, 2018

a17r Sep 30, 2018

waebbl Oct 1, 2018

a17r Sep 30, 2018

a17r Sep 30, 2018

a17r Sep 30, 2018

a17r Sep 30, 2018

a17r Sep 30, 2018

waebbl Oct 1, 2018

a17r Sep 30, 2018

waebbl left a comment

a17r left a comment

a17r Oct 1, 2018

waebbl commented Oct 1, 2018 •

edited

gentoo-repo-qa-bot commented Oct 1, 2018

a17r commented Oct 3, 2018

waebbl commented Oct 3, 2018


		inherit cmake-utils python-single-r1

		DESCRIPTION="Alembic is an open framework for storing and sharing scene data"

media-gfx/alembic: bump to version 1.7.9 #10003

media-gfx/alembic: bump to version 1.7.9 #10003

Conversation

waebbl commented Sep 28, 2018

gentoo-bot commented Sep 28, 2018

Copyright policy change

Pull Request assignment

Linked bugs

waebbl commented Sep 28, 2018

waebbl commented Sep 30, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

waebbl left a comment

Choose a reason for hiding this comment

a17r left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

waebbl commented Oct 1, 2018 • edited

gentoo-repo-qa-bot commented Oct 1, 2018

Pull request CI report

a17r commented Oct 3, 2018

waebbl commented Oct 3, 2018

waebbl commented Oct 1, 2018 •

edited