Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/electron: Bump to 1.6.18, 1.7.15, and 2.0.10 #10009

Closed
wants to merge 2 commits into from

Conversation

elprans
Copy link
Contributor

@elprans elprans commented Sep 28, 2018

This adds electron-2.0.10 and picks up latest security
and compilation fixes for 1.6.x and 1.7.x.

Closes: https://bugs.gentoo.org/661050
Closes: https://bugs.gentoo.org/649308
Package-Manager: Portage-2.3.49, Repoman-2.3.10
Signed-off-by: Elvis Pranskevichus elvis@magic.io

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. labels Sep 28, 2018
@elprans elprans force-pushed the electron-upgrade-2.0 branch 3 times, most recently from 4044b96 to 936749f Compare September 28, 2018 22:31
@infirit
Copy link

infirit commented Sep 30, 2018

Build failure with 1.6.18

Building gn using itself to out/Release...
DEBUG:root:Running: /var/tmp/portage/dev-util/electron-1.6.18/work/temp/tmpBsiv_z/gn gen /var/tmp/portage/dev-util/electron-1.6.18/work/electron-1.6.18/chromium/out/Release --args= is_debug=false enabl
[electron-1.6.18:20180930-150306.log](https://github.com/gentoo/gentoo/files/2431678/electron-1.6.18.20180930-150306.log)
e_nacl=false use_cups=true use_gconf=false use_gnome_keyring=true use_gtk3=false use_kerberos=false use_pulseaudio=true fieldtrial_testing_like_official_build=true is_clang=false use_gold=false use_sysroot=false linux_use_bundled_binutils=false proprietary_codecs=true ffmpeg_branding="Chrome" google_api_key="AIzaSyDEAOvatFo0eTgsV_ZlEzx0ObmepsMzfAc" google_default_client_id="329227923882.apps.googleusercontent.com" google_default_client_secret="vgKG0NNv7GoDpbtoFNLxCUXu" treat_warnings_as_errors=false fatal_linker_warnings=false custom_toolchain="/var/tmp/portage/dev-util/electron-1.6.18/files/toolchain:default" icu_use_data_file=false root_extra_deps = ["//chromiumcontent:chromiumcontent"] is_electron_build = true is_component_build = false use_allocator="none" is_debug=false
ERROR at //BUILD.gn:73:1: Can't load input file.
group("gn_all") {
^----------------
Unable to load:
  /var/tmp/portage/dev-util/electron-1.6.18/files/toolchain/BUILD.gn
I also checked in the secondary tree for:
  /var/tmp/portage/dev-util/electron-1.6.18/files/toolchain/BUILD.gn
Command '['/var/tmp/portage/dev-util/electron-1.6.18/work/temp/tmpBsiv_z/gn', 'gen', '/var/tmp/portage/dev-util/electron-1.6.18/work/electron-1.6.18/chromium/out/Release', '--args= is_debug=false enable_nacl=false use_cups=true use_gconf=false use_gnome_keyring=true use_gtk3=false use_kerberos=false use_pulseaudio=true fieldtrial_testing_like_official_build=true is_clang=false use_gold=false use_sysroot=false linux_use_bundled_binutils=false proprietary_codecs=true ffmpeg_branding="Chrome" google_api_key="AIzaSyDEAOvatFo0eTgsV_ZlEzx0ObmepsMzfAc" google_default_client_id="329227923882.apps.googleusercontent.com" google_default_client_secret="vgKG0NNv7GoDpbtoFNLxCUXu" treat_warnings_as_errors=false fatal_linker_warnings=false custom_toolchain="/var/tmp/portage/dev-util/electron-1.6.18/files/toolchain:default" icu_use_data_file=false root_extra_deps = ["//chromiumcontent:chromiumcontent"] is_electron_build = true is_component_build = false use_allocator="none" is_debug=false']' returned non-zero exit status 1

electron-1.6.18:20180930-150306.log

@elprans elprans changed the title dev-util/electron: Bump to 1.6.16, 1.7.15, and 2.0.10 dev-util/electron: Bump to 1.6.18, 1.7.15, and 2.0.10 Oct 1, 2018
@elprans
Copy link
Contributor Author

elprans commented Oct 1, 2018

Build failure with 1.6.18

Builds fine for me. Did you forget to copy the $FILESDIR?

@infirit
Copy link

infirit commented Oct 1, 2018

Yeah, I indeed forgot something. Builds fine now, thx. Atom is showing some font problems but that is out of scope of this PR.

@infirit
Copy link

infirit commented Oct 1, 2018

Its actually related, see atom/atom#15737. So it would be good to drop 1.6 for 1.7.10 if possible. I'll open a bug on b.g.o if I can make atom work with it.

@elprans
Copy link
Contributor Author

elprans commented Oct 1, 2018

@infirit There is no need. I will post atom-1.31.1 (which uses electron-2.0) once this is merged. You can find it in the atom overlay meanwhile.

@lkraav
Copy link
Contributor

lkraav commented Oct 2, 2018

I'd like to point out, based on work done in https://gitlab.com/chaoslab/chaoslab-overlay/issues/33#note_97608802, that electron-2.0.6 and later (2.0.10 was also tested) may exhibit some kind of renderer crashing behavior. It may be necessary to also keep 2.0.5 ebuild around for a while, so further testing could be done.

Chaos overlay tested w/ electron-bin, so it would be useful to do a local build on later branch releases and see if it crashes the same way, or not.

@elprans
Copy link
Contributor Author

elprans commented Oct 2, 2018

@lkraav I'm using 2.0.10 with Atom 1.31 and VSCode 1.27 with no issues whatsoever. The crashes are likely only in the binary version.

This adds electron-2.0.10 and picks up latest security
and compilation fixes for 1.6.x and 1.7.x.

Closes: https://bugs.gentoo.org/661050
Closes: https://bugs.gentoo.org/649308
Package-Manager: Portage-2.3.49, Repoman-2.3.10
Signed-off-by: Elvis Pranskevichus <elvis@magic.io>
These have security vulnerabilities and compilation issues.

Package-Manager: Portage-2.3.49, Repoman-2.3.10
Signed-off-by: Elvis Pranskevichus <elvis@magic.io>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-10-05 20:38 UTC
Newest commit scanned: 5e81e3f
Status: ✅ good

No issues found

@elprans elprans changed the title dev-util/electron: Bump to 1.6.18, 1.7.15, and 2.0.10 dev-util/electron: Bump to 1.6.18, 1.7.15, and 2.0.10 [please reassign] Oct 16, 2018
@gentoo-bot gentoo-bot changed the title dev-util/electron: Bump to 1.6.18, 1.7.15, and 2.0.10 [please reassign] dev-util/electron: Bump to 1.6.18, 1.7.15, and 2.0.10 Oct 16, 2018
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-util/electron

dev-util/electron: @elprans, @gentoo/proxy-maint

Linked bugs

Bugs linked: 661050, 649308


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. no signoff One or more commits do not indicate GCO sign-off. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) labels Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants