Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sci-libs/Rtree: bump to 0.8.3_p20180802 #10049

Closed
wants to merge 1 commit into from
Closed

sci-libs/Rtree: bump to 0.8.3_p20180802 #10049

wants to merge 1 commit into from

Conversation

TheChymera
Copy link
Contributor

And bumped EAPI to 7
And added test suite

Package-Manager: Portage-2.3.50, Repoman-2.3.11
Signed-off-by: Horea Christian horea.christ@gmail.com

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: sci-libs/Rtree

sci-libs/Rtree: slis

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits. labels Oct 2, 2018
@TheChymera TheChymera mentioned this pull request Oct 2, 2018
Closed
@TheChymera TheChymera mentioned this pull request Oct 21, 2018
Closed
@TheChymera
Copy link
Contributor Author

@mgorny could you also help me merge this one? :)

mgorny
mgorny requested changes Oct 26, 2018
View reviewed changes
sci-libs/Rtree/Rtree-0.8.3_p20180802.ebuild Outdated Show resolved Hide resolved
sci-libs/Rtree/Rtree-0.8.3_p20180802.ebuild Outdated Show resolved Hide resolved
sci-libs/Rtree/Rtree-0.8.3_p20180802.ebuild Outdated Show resolved Hide resolved
sci-libs/Rtree/Rtree-0.8.3_p20180802.ebuild Outdated Show resolved Hide resolved
mgorny
mgorny approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now. I'll merge it.

mgorny
mgorny requested changes Oct 30, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or not. Are you the enemy of repoman?

  dependency.bad [fatal]        18
   sci-libs/Rtree/Rtree-0.8.3_p20180802.ebuild: RDEPEND: ~amd64(default/linux/amd64/17.0)
[     'sci-libs/scipy[python_targets_python2_7(-)?,python_targets_python3_5(-)?,python_targets_python3_6(-)?,python_targets_python3_7(-)?,-python_single_target_python2_7(-),-python_single_target_python3_5(-),-python_single_target_python3_6(-),-python_single_target_python3_7(-)]']

Also, I'm wondering why the tests pass. Is scipy really a dependency?

@TheChymera
Copy link
Contributor Author

@mgorny this is very strange indeed, this came about after showering the scipy dep with my [${PYTHON_USEDEP}] love. The dep was inherited from the previous version, but looking at the source code it seems this package never imports or mentions scipy, and the test suite passes without it being installed. I'll just drop it then.

@TheChymera
Copy link
Contributor Author

@mgorny this is resolved now

@TheChymera
Copy link
Contributor Author

TheChymera commented Nov 2, 2018 •
edited

@mgorny @Zlogene ping?

@TheChymera
sci-libs/Rtree: bump to 0.8.3_p20180802
c348d50 
And bumped EAPI to 7
And added test suite

Package-Manager: Portage-2.3.50, Repoman-2.3.11
Signed-off-by: Horea Christian <horea.christ@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-11-02 22:00 UTC
Newest commit scanned: c348d50
Status: ✅ good

No issues found

mgorny
mgorny approved these changes Nov 3, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@gentoo-bot gentoo-bot closed this in 3a8f925 Nov 3, 2018
@TheChymera TheChymera deleted the Rtree branch November 3, 2018 17:03
Perlovka pushed a commit to Perlovka/gentoo that referenced this pull request Nov 4, 2018
@TheChymera @Perlovka
sci-libs/Rtree: bump to 0.8.3_p20180802
204436b 
And bumped EAPI to 7
And added test suite

Package-Manager: Portage-2.3.50, Repoman-2.3.11
Signed-off-by: Horea Christian <horea.christ@gmail.com>
Closes: gentoo#10049
Signed-off-by: Michał Górny <mgorny@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zlogene Zlogene Zlogene requested changes

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
5 participants
@TheChymera @gentoo-bot @gentoo-repo-qa-bot @mgorny @Zlogene