x11-themes/numix-gtk-theme: fix build issue with dev-ruby/sass #10163
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentAreas affected: ebuilds x11-themes/numix-gtk-theme: @juippis, @gentoo/proxy-maint Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
| @@ -18,4 +18,5 @@ RDEPEND="dev-libs/libxml2 | |||
| DEPEND="${RDEPEND} | |||
| dev-libs/glib:2 | |||
| dev-ruby/sass:* | |||
| !=dev-ruby/sass-3.4.25-r1 | |||
There was a problem hiding this comment.
Weak blockers are used to solve file collisions. They don't guarantee that sass-3.4.25-r1 will be unmerged prior to installing this.
There was a problem hiding this comment.
Yeah, I was thinking of doing the
|| (
<dev-ruby/sass-3.4.25-r1
>dev-ruby/sass-3.4.25-r1
)
solution, whatever correct syntax might be but you get the idea. In the end however to my eyes this !... looked better. It doesn't need to be uninstalled, as sass-3.4.25-r1 can co-exist with sass:3.5 (it's slotted). I think the whole idea of 3.4.25-r1 is so its libraries can co-exist with :3.5 slot of sass, since the only colliding parts are the binaries.
I tested this solution and it does pull another version of sass if 3.4.25-r1 is the only installed one, but I can switch it to a solution mentioned above, too. I was hoping ruby team would do something about it, since this whole situation is a bit weird, but the -r1 bump seems intentional so there must be a good reason this "broken" package still exists in Gentoo. :I
There was a problem hiding this comment.
I mean, you have to use strong blocker to enforce it.
There was a problem hiding this comment.
I gave it a thought and maybe blocker isn't the best choice, since 3.4.25-r1 can be installed IF other version from another slot is present in the system too.
I'm gonna switch this into || ( <dev-ruby/sass-3.4.25-r1 >dev-ruby/sass-3.4.25-r1 ). I'll test the logic to make sure it works, and update this PR if it does.
There was a problem hiding this comment.
Maybe make it >=dev-ruby/sass-3.5, in case -r2 was ever added with same problem. Also, >= should go first as the preferable solution.
There was a problem hiding this comment.
Good point. Yeah I thought about adding >=dev-ruby/sass-3.5 as dep too, it's a shame that previous versions still do work though. However I have no intention of asking this to be stabilized (where 3.4 is needed) so I'll switch to that and commit update soonish.
Bug: https://bugs.gentoo.org/664930 Closes: https://bugs.gentoo.org/664918 Signed-off-by: Joonas Niilola <juippis@gmail.com> Package-Manager: Portage[mgorny]-2.3.49.1
Pull request CI reportReport generated at: 2018-10-20 09:17 UTC No issues found |
|
Cheers, one less bug open :) |
Since there has been no reply from the ruby team in 2 months, I guess this fix also applies and the bug can be closed now.
See:
https://bugs.gentoo.org/show_bug.cgi?id=664930
https://bugs.gentoo.org/664918
Couldn't figure out a way to kinda automatically pull a different version of sass if 3.4.25-r1 is installed, but this prevents the installation if only 3.4.25-r1 is available (since it fails with it).