net-im/skypeforlinux - Add runtime dependencies for logind

[oniGino]

Closes: https://bugs.gentoo.org/666396

Signed-off-by: Gino B onigino@protonmail.com
Reported-by: Guillaume Castagnino casta@xwing.info

[gentoo-bot]

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-im/skypeforlinux

net-im/skypeforlinux: @oniGino, @gentoo/proxy-maint

Linked bugs

Bugs linked: 666396

---

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

[gentoo-repo-qa-bot]

Pull request CI report

Report generated at: 2018-10-24 19:18 UTC
Newest commit scanned: 4b57534
Status: ✅ good

No issues found

[logistiker]

I think there is a problem with this commit. This affects users who cannot have elogind installed with openrc and teamviewer. The point is to stop skypeforlinux from segfaulting while using openrc and consolekit. This affectively forces the user to use systemd or it's lesser package, elogind while ignoring conflicts from other packages like teamviewer. In addition, I do not appreciate bug 668752 being closed as won't fix even after I've offered to submit a skype-dbus-mock ebuild as an additional solution to the problem.

[oniGino]

you can submit skype-dbus-mock if you like, and as stated in the bug, if it makes it in tree I'll add support for it. But if you look at the code for it, its a mess, it attempts to respond to all login1 dbus calls. No doubt this fixes the issue for the narrow corner case of users openrc/consolekit, but breaks all other attempts to call login1 by all other services. So that isn't just a fix for skype is it? more of a login1 dbus emulator or something.
Also this isn't the appropriate place to discuss that issue. so perhaps redirect that discussion there (discuss further in bug 668752 i mean)

As for this PR:

Upstream demands the existence of the systemd logind service only two packages exist in tree which resolve this issue. elogind and systemd. No solution upstream exists for users of openrc+consolekit.
Its in effect not support by microsoft.

I don't maintain teamviewer its not my job to maintain or support it

[logistiker]

If you look at the ebuild that is part of that package, you'll notice that it blocks elogind and systemd from being installed so I don't see how creating a login1 dbus emulator is a problem since all it's doing is pretending to act like elogind and if that's not allowed to be installed, then what else would conflict with it?

Regarding what Microsoft supports, Gentoo has allowed non-supported software in the past (apulse) to be used along with Skype, so while it's not a great solution, skype-dbus-mock does appear to fix the problem and may be a solution for other cases like the teamviewer problem. Frankly, I like solutions that work for everyone and we can certainly have both.

Also, if skype-dbus-mock does get added, then by all means, when you add support for it in skypeforlinux ebuild, you can warn users that it's a solution not supported by Microsoft.

[mgorny]

: instead of - in the commit message, and full name into signoff.

[mgorny]

Closing in favor of #10228.