sci-libs/ipopt: Version bump to 3.12.12, EAPI 5 -> 6 #10293
Conversation
Copyright policy changePlease note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article. Pull Request assignmentAreas affected: ebuilds sci-libs/ipopt: @gentoo/sci Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. Missing GCO sign-offPlease read the terms of Gentoo Certificate of Origin and acknowledge them by adding a sign-off to all your commits. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
g-braeunlich
force-pushed
the
ipopt
branch
3 times, most recently
from
58806de
to
26246ce
Compare
g-braeunlich
force-pushed
the
ipopt
branch
3 times, most recently
from
0c3a0eb
to
b9b8f35
Compare
|
@SoapGentoo or @a17r : Could you have a look at this? |
sci-libs/ipopt/ipopt-3.12.11.ebuild
Outdated
| src_configure() { | ||
| # needed for the --with-coin-instdir | ||
| dodir /usr | ||
| local myeconfargs |
There was a problem hiding this comment.
What is the reason for moving the standard args out of the nice array and regressing them with \ chars towards econf? I'd much rather see a clean econf "${myeconfargs[@]}" at the end. Also, having the related cmake arg right there is much nicer wrt the comment above.
sci-libs/ipopt/ipopt-3.12.11.ebuild
Outdated
| local mumps_include="${EPREFIX}"/usr/include | ||
| ! use mpi && mumps_include="${EPREFIX}/usr/include/mpiseq/" | ||
| myeconfargs+=( | ||
| --with-mumps-incdir="$mumps_include" |
There was a problem hiding this comment.
how about
--with-mumps-incdir="${EPREFIX}"/usr/include$(usex mpi '' '/mpiseq')
instead?
sci-libs/ipopt/ipopt-3.12.11.ebuild
Outdated
| src_install() { | ||
| default | ||
|
|
||
| use doc && HTML_DOCS=("${AUTOTOOLS_BUILD_DIR}/doxydocs/html/.") |
sci-libs/ipopt/ipopt-3.12.11.ebuild
Outdated
| default | ||
|
|
||
| use doc && HTML_DOCS=("${AUTOTOOLS_BUILD_DIR}/doxydocs/html/.") | ||
| use examples && DOCS+=( examples ) |
sci-libs/ipopt/ipopt-3.12.11.ebuild
Outdated
| } | ||
|
|
||
| src_configure() { | ||
| # needed for the --with-coin-instdir |
sci-libs/ipopt/ipopt-3.12.11.ebuild
Outdated
| } | ||
|
|
||
| src_compile() { | ||
| emake all $(use doc && echo doxydoc) |
There was a problem hiding this comment.
a separate use doc && emake doxydoc would get rid of an unnecessary subshell and external command.
sci-libs/ipopt/ipopt-3.12.11.ebuild
Outdated
| use examples && DOCS+=( examples ) | ||
| einstalldocs | ||
|
|
||
| rm -rf "${ED%/}"/usr/share/coin || die |
There was a problem hiding this comment.
Regarding rm -f: Do we have reason to believe that this path may not always be there? If not, would it be preferable to have the build actually fail and notify us about that circumstance?
sci-libs/ipopt/ipopt-3.12.11.ebuild
Outdated
| src_install() { | ||
| default | ||
|
|
||
| use doc && HTML_DOCS=("${AUTOTOOLS_BUILD_DIR}/doxydocs/html/.") |
There was a problem hiding this comment.
AUTOTOOLS_BUILD_DIR is not a thing since you dropped autotools-utils, you'll have to get the path another way.
FileNotFoundError: [Errno 2] No such file or directory: b'/doxydocs/html/.'
* ERROR: sci-libs/ipopt-3.12.11::gentoo failed (install phase):
* dodoc failed
|
@a17r : Thank you very much for your review - everything makes totally sense to me! |
g-braeunlich
changed the title
g-braeunlich
force-pushed
the
ipopt
branch
3 times, most recently
from
fade572
to
51a2fab
Compare
|
Tested so far: Appending /home/g/.portage/g-braeunlich to PORTDIR_OVERLAY...
|
|
Adding RESTRICT="test" for now. |
Signed-off-by: Gerhard Bräunlich <g.braeunlich@disroot.org> Package-Manager: Portage-2.3.40, Repoman-2.3.9
|
Also tested it with mpi now. |
Pull request CI reportReport generated at: 2019-03-10 14:20 UTC No issues found |
Package-Manager: Portage-2.3.40, Repoman-2.3.9
Checked building everything (including test), except use flag doc (at the moment I only have a sabayon notebook. There it is very complicated to build doxygen with latex without breaking the package management).
I also noticed, that @mgorny blocked the hsl use flag.
In another PR, I will provide an updated Version of coinhsl. ipopt builds fine with this version, and I also successfully tested ipopt with hsl's ma97 solver.
Thus the block could maybe removed?