Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 #10296

Closed
wants to merge 1 commit into from
Closed

media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 #10296

wants to merge 1 commit into from

Conversation

4z0r
Copy link
Contributor

@4z0r 4z0r commented Oct 29, 2018 •
edited

The driver is downloaded from EPSON directly; in a bundle with the desired library.
Only the specific bundle is extracted. The drive has it's own ebuild.

Closes: https://bugs.gentoo.org/406425
Suggested-by: Kelzhadant kelzhadant@gmail.com
Signed-off-by: Ovidiu - Dan Bogat 4z0r@ovidiu.at

@4z0r 4z0r changed the title Added new ebuild for version bump to 1.1.2 and EAPI=7 media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 Oct 29, 2018
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 29, 2018
@4z0r
Copy link
Contributor Author

4z0r commented Oct 29, 2018

Sources are fetched from EPSON directly:
http://download.ebz.epson.net/dsc/search/01/search/?OSC=LX

The Source however is a bundle with driver and the desired plugin (ebuild should only handle the plugin) which needed additional extraction.

Keywords haven been changed to "-* ~amd64 ~x86", since I can't test the plugin for functionality myself.

See:
https://bugs.gentoo.org/406425

@4z0r 4z0r mentioned this pull request Oct 29, 2018
Closed
@4z0r 4z0r force-pushed the media-gfx/iscan-plugin-gt-f720-version-bump branch 2 times, most recently from ecdc826 to 04fdbaa Compare October 29, 2018 23:50
@4z0r
Copy link
Contributor Author

4z0r commented Oct 29, 2018

merged and squashed the PR #10292 within this one.

Cleaned up the format of the commit message.

@4z0r 4z0r force-pushed the media-gfx/iscan-plugin-gt-f720-version-bump branch from 04fdbaa to d77b842 Compare October 29, 2018 23:54
@4z0r 4z0r changed the title media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 [please reassign] Oct 29, 2018
@gentoo-bot gentoo-bot changed the title media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 [please reassign] media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 Oct 29, 2018
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can. labels Oct 29, 2018
@4z0r 4z0r force-pushed the media-gfx/iscan-plugin-gt-f720-version-bump branch from d77b842 to 205780b Compare October 29, 2018 23:57
@4z0r 4z0r changed the title media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 [please reassign] Oct 29, 2018
@gentoo-bot gentoo-bot changed the title media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 [please reassign] media-gfx/iscan-plugin-gt-f720: version bumpt to 1.1.2 and EAPI=7 Oct 30, 2018
@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: media-gfx/iscan-plugin-gt-f720

media-gfx/iscan-plugin-gt-f720: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 406425

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can. labels Oct 30, 2018
@4z0r
media-gfx/iscan-plugin-gt-f720: version bump to 0.1.1.2 and EAPI bump
144b29b 
Added new ebuild for version bump to 0.1.1.2 using EAPI=7

The plugin is now downloaded from EPSON directrly in a bundle with the
driver.
Only the specific plugin is extracted. The driver has it's own ebuild.

Also bumped the EAPI for the existing version 0.0.1.2 from 4 to 7

Closes: https://bugs.gentoo.org/406425
Suggested-by: Kelzhadant <kelzhadant@gmail.com>
Signed-off-by: Ovidiu - Dan Bogat <4z0r@ovidiu.at>
@4z0r 4z0r force-pushed the media-gfx/iscan-plugin-gt-f720-version-bump branch from 205780b to 144b29b Compare October 30, 2018 01:06
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-10-30 01:37 UTC
Newest commit scanned: 144b29b
Status: ✅ good

No issues found

mgorny
mgorny requested changes Nov 3, 2018
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments apply multiple times. Please reread your ebuild after applying them and fix all occurences.

media-gfx/iscan-plugin-gt-f720/iscan-plugin-gt-f720-0.0.1.2-r1.ebuild
@@ -0,0 +1,55 @@
# Copyright 1999-2018 Gentoo Authors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this ebuild doing? If you're doing a version bump, don't do unnecessary changes to the old version.

media-gfx/iscan-plugin-gt-f720/iscan-plugin-gt-f720-0.1.1.2.ebuild
@@ -0,0 +1,58 @@
# Copyright 1999-2018 Gentoo Foundation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it 1.1.2 or 0.1.1.2?

media-gfx/iscan-plugin-gt-f720/iscan-plugin-gt-f720-0.1.1.2.ebuild
DESCRIPTION="Epson Perfection V300 PHOTO scanner plugin for SANE 'epkowa' backend"
HOMEPAGE="http://download.ebz.epson.net/dsc/search/01/search/?OSC=LX"
SRC_URI="amd64? ( https://download2.ebz.epson.net/iscan/plugin/gt-f720/rpm/x64/iscan-gt-f720-bundle-1.0.1.x64.rpm.tar.gz -> ${PN}-bundle.rpm.tar.gz )
x86? ( https://download2.ebz.epson.net/iscan/plugin/gt-f720/rpm/x86/iscan-gt-f720-bundle-1.0.1.x86.rpm.tar.gz -> ${PN}-bundle.rpm.tar.gz )"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're putting two different files into same file which is obviously wrong and will explode horribly on the other system you haven't tested. Also this is 1.0.1 now, so this ebuild is one horribly big WTF to me.

media-gfx/iscan-plugin-gt-f720/iscan-plugin-gt-f720-0.1.1.2.ebuild

src_unpack() {
unpack "${PN}-bundle.rpm.tar.gz"
mv * "./${PN}-bundle.rpm"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't do * guessing, use a conditional with the correct name instead.

media-gfx/iscan-plugin-gt-f720/iscan-plugin-gt-f720-0.1.1.2.ebuild
}

src_install() {
local MY_LIB="/usr/$(get_libdir)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're using this variable exactly once. Kill it.

media-gfx/iscan-plugin-gt-f720/iscan-plugin-gt-f720-0.1.1.2.ebuild

# install scanner firmware
insinto /usr/share/esci
doins "${WORKDIR}/usr/share/esci/"*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you using absolute path to reference the current directory?

media-gfx/iscan-plugin-gt-f720/iscan-plugin-gt-f720-0.1.1.2.ebuild

# install scanner plugins
insinto "${MY_LIB}/esci"
insopts -m0755
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like you wanted doexe.

@a17r
Copy link
Member

a17r commented Jan 6, 2019

ping

@mgorny
Copy link
Member

mgorny commented Apr 3, 2019

Closing due to no activity.

@mgorny mgorny closed this Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
5 participants
@4z0r @gentoo-bot @gentoo-repo-qa-bot @a17r @mgorny