Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-text/robodoc: 2 version bumps and 1 to EAPI=7 #10307

Closed
wants to merge 2 commits into from
Closed

app-text/robodoc: 2 version bumps and 1 to EAPI=7 #10307

wants to merge 2 commits into from

Conversation

4z0r
Copy link
Contributor

@4z0r 4z0r commented Oct 30, 2018

The version 4.99.36 got an EAPI bump to 7

Robodoc got a version bump to 4.99.41
and another version bump to 4.99.43

The version 4.99.41 needed a patch to cleanup the Docs/makefile.am and a
correction for deprecated usage of configure.in (autotools) - see bug
426262. The other version needed no extra handling.

Closes: https://bugs.gentoo.org/496976
Suggested-by: Geaaru geaaru@gmail.com
Signed-off-by: Ovidiu - Dan Bogat 4z0r@ovidiu.at
Package-Manager: Portage-2.3.49, Repoman-2.3.11

@gentoo-bot
Copy link

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: app-text/robodoc

app-text/robodoc: @gentoo/proxy-maint (maintainer needed)

Linked bugs

Bugs linked: 496976

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Oct 30, 2018
@4z0r 4z0r force-pushed the app-text/robodoc-version-bump branch 2 times, most recently from d6ac69b to 7e7e578 Compare October 30, 2018 16:46
juippis
juippis reviewed Nov 5, 2018
View reviewed changes
app-text/robodoc/Manifest Outdated Show resolved Hide resolved
app-text/robodoc/metadata.xml Outdated Show resolved Hide resolved
app-text/robodoc/robodoc-4.99.36.ebuild Show resolved Hide resolved
app-text/robodoc/robodoc-4.99.43.ebuild Outdated Show resolved Hide resolved
app-text/robodoc/robodoc-4.99.43.ebuild Outdated Show resolved Hide resolved
app-text/robodoc/robodoc-4.99.43.ebuild Outdated Show resolved Hide resolved
app-text/robodoc/robodoc-4.99.43.ebuild Outdated Show resolved Hide resolved
app-text/robodoc/robodoc-4.99.43.ebuild Outdated Show resolved Hide resolved
app-text/robodoc/robodoc-4.99.41.ebuild Outdated Show resolved Hide resolved
app-text/robodoc/robodoc-4.99.41.ebuild Outdated Show resolved Hide resolved
@4z0r
Copy link
Contributor Author

4z0r commented Nov 5, 2018 •
edited

I've kept both commits for now if you'd like to review the changes as per our conversations.

If that's all I'll squash both of them into one single, cleaned up commit.

@juippis
Copy link
Member

juippis commented Nov 6, 2018

Yes, please do squash. The commits are a bit scattered now. If you intend to remove .36 after bumping to latest, it goes into its own separate commit.

So 1st commit is bump to latest with new ebuild,
then 2nd is cleaning of old versions. Example: https://github.com/gentoo/gentoo/pull/10330/commits
You can clean older versions with a separate PR though, if you wish :)

@4z0r
app-text/robodoc: version bump to 4.99.43 EAPI=7
af19797 
Robodoc got a version bump to 4.99.43

Closes: https://bugs.gentoo.org/496976
Suggested-by: Geaaru <geaaru@gmail.com>
Signed-off-by: Ovidiu - Dan Bogat <4z0r@ovidiu.at>
Package-Manager: Portage-2.3.49, Repoman-2.3.11
@4z0r 4z0r force-pushed the app-text/robodoc-version-bump branch from 44801ee to af19797 Compare November 6, 2018 10:07
@4z0r
app-text/robodoc: remove old 4.99.36
daeb5d0 
Signed-off-by: Ovidiu - Dan Bogat <4z0r@ovidiu.at>
Package-Manager: Portage-2.3.49, Repoman-2.3.11
@4z0r
Copy link
Contributor Author

4z0r commented Nov 6, 2018

Done and done. Thanks!

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-11-06 10:39 UTC
Newest commit scanned: daeb5d0
Status: ✅ good

No issues found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
Milestone
No milestone
4 participants
@4z0r @gentoo-bot @juippis @gentoo-repo-qa-bot