kde-base/pykde4: fix bugs in pythonpluginfactorywrapper.c #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: https://bugs.gentoo.org/show_bug.cgi?id=555436 The logic for checking the return value of fork() was inverted, causing the main process to continue as the child process, while the parent process execs. This can confuse libraries and applications that don't expect their PID to suddenly change, and other misc badness (process gets reparented to init, etc.)
|
@gentoo/kde |
monsieurp
added
bugfix
assigned
|
Thanks a lot for your contribution. I've picked it as 22aa5c8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://bugs.gentoo.org/show_bug.cgi?id=555436
The logic for checking the return value of fork() was inverted, causing the main process to continue as the child process, while the parent process execs. This can confuse libraries and applications that don't expect their PID to suddenly change, and other misc badness (process gets reparented to init, etc.).
This patch also fixes other issues (leaked file descriptors, child process left as a zombie, poor error handling).
Steps to reproduce:
Expected results: PID does not change
Actual results: PID changes