Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing more single-use global flags #10408

Closed
wants to merge 13 commits into from
Closed

Removing more single-use global flags #10408

wants to merge 13 commits into from

Conversation

mgorny
Copy link
Member

@mgorny mgorny commented Nov 13, 2018

No description provided.

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 13, 2018
@mgorny mgorny added noci Skip CI for this pull request and removed assigned PR successfully assigned to the package maintainer(s). labels Nov 13, 2018
@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed no bug found No Bug/Closes found in the commits. labels Nov 13, 2018
@mgorny mgorny changed the title Removing more single-use global flags [WIP] Removing more single-use global flags Nov 13, 2018
@mgorny mgorny removed the assigned PR successfully assigned to the package maintainer(s). label Nov 13, 2018
@gentoo-bot
Copy link

gentoo-bot commented Nov 13, 2018 •
edited by mgorny

Copyright policy change

Please note that on 2018-09-15 Trustees have approved new Gentoo copyright policy. All contributions made to Gentoo need to follow this policy. If you include the Signed-off-by line in your commit message, you indicate that you have read the policy and agree to its terms. For more detailed explanation, please see the new Gentoo copyright policy explained article.

Pull Request assignment

Areas affected: ebuilds
Packages affected: app-editors/gvim, app-editors/vim, app-editors/xemacs, app-xemacs/xemacs-packages-all, kde-misc/tellico...

  • app-editors/gvim: @gentoo/vim
  • app-editors/vim: @gentoo/vim
  • app-editors/xemacs: [xemacs (project)]
  • app-emulation/fuse: @atomsymbol, @gentoo/proxy-maint
  • app-xemacs/xemacs-packages-all: [xemacs (project)]
  • kde-misc/tellico: @gentoo/kde
  • media-sound/shntool: @gentoo/sound
  • net-mail/lbdb: @gentoo/net-mail
  • sci-chemistry/ghemical: @gentoo/sci-chemistry
  • sys-boot/grub: @floppym, @axs-gentoo, @gentoo/base-system
  • www-apps/websvn: @gentoo/web-apps
  • www-client/jd: @gentoo/cjk

At least one of the listed packages is maintained entirely by non-GitHub developers!

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits. and removed maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits. labels Nov 13, 2018
@mgorny mgorny added assigned PR successfully assigned to the package maintainer(s). and removed noci Skip CI for this pull request need assignment It was impossible to assign the PR correctly. Please assign it manually. labels Nov 13, 2018
@mgorny mgorny changed the title [WIP] Removing more single-use global flags Removing more single-use global flags Nov 13, 2018
mgorny added a commit to mgorny/gentoo that referenced this pull request Nov 13, 2018
@mgorny
use.desc: Remove now-local-only flags
7799bac 
Closes: gentoo#10408
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
Copy link
Member Author

mgorny commented Nov 13, 2018

Ok, all people CC-ed: please review now. Also sent to gentoo-dev ml.

a17r
a17r suggested changes Nov 13, 2018
View reviewed changes
kde-misc/tellico/metadata.xml Outdated Show resolved Hide resolved
floppym
floppym suggested changes Nov 13, 2018
View reviewed changes
Copy link
Contributor

@floppym floppym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you forgot to remove "netboot" from use.desc.

ghost
ghost suggested changes Nov 13, 2018
View reviewed changes
app-emulation/fuse/metadata.xml Outdated
@@ -17,5 +17,6 @@
<flag name="backend-sdl">Use SDL rendering backend</flag>
<flag name="backend-svga">Use svgalib rendering backend</flag>
<flag name="backend-X">Use X11 rendering backend</flag>
<flag name="memlimit">Add memory usage limiting</flag>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that it lowers compile-time memory usage of z80_ops.c from 263 MiB to 140 MiB with gcc 7.3.0, and from 137 MiB to 117 MiB with clang-7.0.0. Since it applies to compile-time only (not to runtime memory usage), I suggest modifying it to "Add compile-time memory usage limiting".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sounds like I did the same thing in pypy as low-memory. memlimit makes me think more of allowing user to set a limit on memory usage.

@mgorny
www-apps/websvn: Make USE=enscript a local flag
b19a008 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
net-mail/lbdb: Make USE=evo local
3f626c7 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
mgorny added a commit to mgorny/gentoo that referenced this pull request Nov 16, 2018
@mgorny
use.desc: Remove now-local-only flags
63bde6a 
Closes: gentoo#10408
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
Copy link
Member Author

mgorny commented Nov 16, 2018

@floppym, hmm, I see it being removed.

@mgorny
app-emulation/fuse: Make USE=memlimit local
ce791e5 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
www-client/jd: Make USE=migemo local
05229c3 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
sys-boot/grub: Make USE=netboot local
ffb1b82 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
sci-chemistry/ghemical: Make USE=seamonkey local
b00dc3d 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
media-sound/shntool: Make USE=shorten local
5cada3f 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
kde-misc/tellico: Make USE=yaz local
51fd185 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
app-editors/vim: Make USE=cscope local
899a110 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
app-editors/gvim: Make USE=cscope local
489bfae 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
app-editors/xemacs: Make USE=mule local
4526e02 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
app-xemacs/xemacs-packages-all: Make USE=mule local
666240f 
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@mgorny
use.desc: Remove now-local-only flags
0b0c867 
Closes: gentoo#10408
Signed-off-by: Michał Górny <mgorny@gentoo.org>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-11-16 10:19 UTC
Newest commit scanned: 0b0c867
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/96ee29a/output.html#dev-python/django_polymorphic

@floppym
Copy link
Contributor

floppym commented Nov 16, 2018

@floppym, hmm, I see it being removed.

That's because you force-pushed a new commit after I left my comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r requested changes

@floppym floppym floppym approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can. no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
5 participants
@mgorny @gentoo-bot @gentoo-repo-qa-bot @floppym @a17r